New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naked `File`s can result in WIX0095 errors in mysterious circumstances #8674

Closed

1 task done

barnson opened this issue Aug 2, 2024 · 0 comments · Fixed by wixtoolset/wix#557

Closed

1 task done

Naked `File`s can result in WIX0095 errors in mysterious circumstances #8674

barnson opened this issue Aug 2, 2024 · 0 comments · Fixed by wixtoolset/wix#557

Assignees

Labels

Milestone

Member

barnson commented Aug 2, 2024

WiX Version

5.0.1

.NET or MSBuild or Visual Studio Version

n/a

HeatWave Version

n/a

Windows Version

n/a

Repro Repo

No response

Repro Steps

Create a .wxs file. wix0095.zip
Build it: wix build package.wxs

Actual Result

path\to\package.wxs(4) : error WIX0095: Multiple primary references were found for Component 'filbnxAhte7CMAiUkJkbiTH7FDb69c' in Feature 'WixDefaultFeature' and Feature 'WixDefaultFeature'.
path\to\package.wxs(5) : error WIX0095: Multiple primary references were found for Component 'filbnxAhte7CMAiUkJkbiTH7FDb69c' in Feature 'WixDefaultFeature' and Feature 'WixDefaultFeature'.
path\to\package.wxs(6) : error WIX0095: Multiple primary references were found for Component 'filbnxAhte7CMAiUkJkbiTH7FDb69c' in Feature 'WixDefaultFeature' and Feature 'WixDefaultFeature'.
path\to\package.wxs(7) : error WIX0095: Multiple primary references were found for Component 'filbnxAhte7CMAiUkJkbiTH7FDb69c' in Feature 'WixDefaultFeature' and Feature 'WixDefaultFeature'.

Expected Result

The files are going to different Subdirectorys, so there should not be duplicate anything, even though the file Names are the same. (The component ids are duplicated.)

Acknowledgements

I acknowledge that this is a fully completed bug report. It is not a question or attempt to get help debugging my issue (because those should be sent to Discussions).

The text was updated successfully, but these errors were encountered:

barnson added the triage label

barnson added a commit to wixtoolset/wix that referenced this issue


          Ensure naked files take Subdirectory into account.

c99b350

Naked files generated their ids using the attributes that are common to
both naked and clothed files. But naked files also support @subdirectory
to magic up a subdirectory in a specified directory (@Directory) or the
default INSTALLFOLDER. That subdirectory needs to factor in to the
generated file id (which is then used as the component id too).
Without it, generated ids for files with the same name but from
different @subdirectory values would be duplicated. (Authored file ids
must also continue to be supported.)

Naked files now generate different file and component ids. :(

Fixes wixtoolset/issues#8674

barnson mentioned this issue

Ensure naked files take Subdirectory into account. wixtoolset/wix#557

Merged

barnson added a commit to wixtoolset/wix that referenced this issue


          Ensure naked files take Subdirectory into account.

d9c3799

Naked files generated their ids using the attributes that are common to
both naked and clothed files. But naked files also support @subdirectory
to magic up a subdirectory in a specified directory (@Directory) or the
default INSTALLFOLDER. That subdirectory needs to factor in to the
generated file id (which is then used as the component id too).
Without it, generated ids for files with the same name but from
different @subdirectory values would be duplicated. (Authored file ids
must also continue to be supported.)

Naked files now generate different file and component ids. :(

Fixes wixtoolset/issues#8674

barnson added a commit to wixtoolset/wix that referenced this issue


          Ensure naked files take Subdirectory into account.

e804d30

Naked files generated their ids using the attributes that are common to
both naked and clothed files. But naked files also support @subdirectory
to magic up a subdirectory in a specified directory (@Directory) or the
default INSTALLFOLDER. That subdirectory needs to factor in to the
generated file id (which is then used as the component id too).
Without it, generated ids for files with the same name but from
different @subdirectory values would be duplicated. (Authored file ids
must also continue to be supported.)

Naked files now generate different file and component ids. :(

Fixes wixtoolset/issues#8674

barnson self-assigned this

barnson added compiler and removed triage labels

barnson added this to the v6.0.0-rc.1 milestone

barnson added a commit to wixtoolset/wix that referenced this issue


          Ensure naked files take Subdirectory into account.

b29798a

Naked files generated their ids using the attributes that are common to
both naked and clothed files. But naked files also support @subdirectory
to magic up a subdirectory in a specified directory (@Directory) or the
default INSTALLFOLDER. That subdirectory needs to factor in to the
generated file id (which is then used as the component id too).
Without it, generated ids for files with the same name but from
different @subdirectory values would be duplicated. (Authored file ids
must also continue to be supported.)

Naked files now generate different file and component ids. :(

Fixes wixtoolset/issues#8674

barnson added a commit to wixtoolset/wix that referenced this issue


          Ensure naked files take Subdirectory into account.

b2d7e5b

Naked files generated their ids using the attributes that are common to
both naked and clothed files. But naked files also support @subdirectory
to magic up a subdirectory in a specified directory (@Directory) or the
default INSTALLFOLDER. That subdirectory needs to factor in to the
generated file id (which is then used as the component id too).
Without it, generated ids for files with the same name but from
different @subdirectory values would be duplicated. (Authored file ids
must also continue to be supported.)

Naked files now generate different file and component ids. :(

Fixes wixtoolset/issues#8674

robmen closed this as completed in wixtoolset/wix#557

robmen closed this as completed in


      wixtoolset/wix@720708f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment