How to create reusable element and install VC Redistributables (c++) before installing my app(s) by referencing in multiple products #8735

vdrasutis · 2024-09-05T09:37:33Z

vdrasutis
Sep 5, 2024

Hello.

We have a "VCRedistributables.wxs" and used Wix v3:

<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
	<Fragment>  
    
    <!-- 64 bit VC++ merge modules  v2015-2022 -->
    <FeatureGroup Id="VCRedistributable64">
      <MergeRef Id="Microsoft_VC143_CRT_x64"/>
      <MergeRef Id="Microsoft_VC143_MFC_x64"/>
      <MergeRef Id="Microsoft_VC143_MFCLOC_x64"/>
      <MergeRef Id="Microsoft_VC143_OpenMP_x64"/>
      <MergeRef Id="Microsoft_VC143_CXXAMP_x64"/>
    
      <ComponentRef Id="VC2022Redist" />
    </FeatureGroup>

    <DirectoryRef Id="TARGETDIR">
      <Merge Id="Microsoft_VC143_CRT_x64" Language="0" SourceFile="..\ThirdpartyBinariesx64\VcMergeModules\Microsoft_VC143_CRT_x64.msm" DiskId="1" />
      <Merge Id="Microsoft_VC143_MFC_x64" Language="0" SourceFile="..\ThirdpartyBinariesx64\VcMergeModules\Microsoft_VC143_MFC_x64.msm" DiskId="1" />
      <Merge Id="Microsoft_VC143_MFCLOC_x64" Language="0" SourceFile="..\ThirdpartyBinariesx64\VcMergeModules\Microsoft_VC143_MFCLOC_x64.msm" DiskId="1" />
      <Merge Id="Microsoft_VC143_OpenMP_x64" Language="0" SourceFile="..\ThirdpartyBinariesx64\VcMergeModules\Microsoft_VC143_OpenMP_x64.msm" DiskId="1" />
      <Merge Id="Microsoft_VC143_CXXAMP_x64" Language="0" SourceFile="..\ThirdpartyBinariesx64\VcMergeModules\Microsoft_VC143_CXXAMP_x64.msm" DiskId="1" />
      
    </DirectoryRef>
	
    <DirectoryRef Id="TARGETDIR">
      <Directory Id="System64Folder" FileSource="..\ThirdpartyBinariesx64\VcMergeModules">
        <Component Id="VC2022Redist" Guid="20F20857-EF99-4CED-B7E1-4094855AAAEA" Permanent="yes">
          <File Id="console" Name="api-ms-win-core-console-l1-1-0.dll"/>
          <File Id="console12" Name="api-ms-win-core-console-l1-2-0.dll"/>
          <File Id="datetime" Name="api-ms-win-core-datetime-l1-1-0.dll"/>
          <File Id="debug" Name="api-ms-win-core-debug-l1-1-0.dll"/>
          <File Id="errorhandling" Name="api-ms-win-core-errorhandling-l1-1-0.dll"/>
          <File Id="file11" Name="api-ms-win-core-file-l1-1-0.dll"/>
          <File Id="file12" Name="api-ms-win-core-file-l1-2-0.dll"/>
          <File Id="file21" Name="api-ms-win-core-file-l2-1-0.dll"/>
          <File Id="handle" Name="api-ms-win-core-handle-l1-1-0.dll"/>
          <File Id="heap" Name="api-ms-win-core-heap-l1-1-0.dll"/>
          ...
        </Component>
      </Directory>
    </DirectoryRef>
    
	</Fragment>
</Wix>

And then used in multiple features/producs like this using "FeatureGroupRef ":

<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
  <Fragment>

    <!-- Root vendor feature -->
    <Feature Id="VendorFeature" Title="Vendors" Level="5">
      ...

      <!-- VC++ redistributables -->
      <FeatureGroupRef Id="VCRedistributable64"/>

    </Feature>
  </Fragment>
</Wix>

Now I run wix conversion to v4.

After converions it was complaining about Merge files Parent - as it was under "Fragment"
As we have plan also update/replace merge files usage to include full VC Redistributable executable (as merge files are deprecated and not recommended to use. By googling, searching I came whit element like this:

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <!--https://github.com/search?q=org%3Awixtoolset+FileRef%3D%22&type=code-->
  <Fragment><!-- 64 bit VC++ merge modules  v2015-2022 -->
      <Component Id="VCRedist_x64">
        <File Id="VCRedist_x64_File" Source="..\ThirdpartyBinariesx64\VcRedist\vc_redist.x64.exe" KeyPath="yes" />
      </Component>
    
      <CustomAction Id="InstallVCRedist" FileRef="VCRedist_x64_File" Execute="immediate" ExeCommand="/install /quiet /norestart" Return="ignore" Impersonate="no"/>

      <InstallExecuteSequence>
        <Custom Action="InstallVCRedist" Before="InstallInitialize"></Custom>
      </InstallExecuteSequence>
  </Fragment>

</Wix>

And then I reference in the Feature/products like this (as by your video not sure if it counts as a dependency but if I use something from fragment, then it is all is pulled in? https://www.youtube.com/watch?v=DH12kv2CmQ4&t=319s):
<ComponentRef Id="VCRedist_x64" />

But I get error during installation, and log does not say anything useful why it fails "install.log":

=== Verbose logging started: 04/09/2024  23:14:53  Build type: SHIP UNICODE 5.00.10011.00  Calling process: C:\WINDOWS\system32\msiexec.exe ===
MSI (c) (CC:14) [23:14:53:931]: Font created.  Charset: Req=0, Ret=0, Font: Req=MS Shell Dlg, Ret=MS Shell Dlg

MSI (c) (CC:14) [23:14:53:931]: Font created.  Charset: Req=0, Ret=0, Font: Req=MS Shell Dlg, Ret=MS Shell Dlg

MSI (c) (CC:FC) [23:14:53:970]: Resetting cached policy values
MSI (c) (CC:FC) [23:14:53:970]: Machine policy value 'Debug' is 0
MSI (c) (CC:FC) [23:14:53:970]: ******* RunEngine:
           ******* Product: .\ariesoGeoSCMInstaller_x64_doesNotWork.msi
           ******* Action: 
           ******* CommandLine: **********
MSI (c) (CC:FC) [23:14:53:972]: Machine policy value 'DisableUserInstalls' is 0
MSI (c) (CC:FC) [23:14:53:992]: Note: 1: 1402 2: HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Policies\Explorer 3: 2 
MSI (c) (CC:FC) [23:14:53:992]: Note: 1: 1324 2: . 3: 1 
MSI (c) (CC:FC) [23:14:53:992]: MainEngineThread is returning 2
=== Verbose logging stopped: 04/09/2024  23:14:54 ===

Would really appreciate any help ideas what I am missing, thanks.

Answered by vdrasutis

Oct 2, 2024

Thanks @michaelgburton for idea.

Have you considered creating a bundle and using an approach like this instead for the VC Redistributables?

https://gist.github.com/nathancorvussolis/557d1c4faccd5c83d88be606c60430d0

Here is my sample of the project and using reusable component.
Note: I did changed some names - so might miss some, it is only for high view how to...

Project file:

<Project Sdk="WixToolset.Sdk/5.0.1">
  <PropertyGroup>
    <OutputType>Bundle</OutputType>
    <Platform Condition=" '$(Platform)' == '' ">x64</Platform>
    <OutputName>Installer_$(Platform)_Bundle</OutputName>
  </PropertyGroup>
  <!--<Import Project="$(SourceRoot)\GEO.Common.targets" />-->
  <PropertyGroup Cond…

View full answer

vdrasutis · 2024-09-05T11:51:54Z

vdrasutis
Sep 5, 2024
Author

For now have this code below - it does not throw any error, my app installs successfully but VC Redistributable is still not installed :( :

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Fragment>
        
    <Component Id="VCRedist_Component_X64">
      <File Id="VCRedist_File_X64"
            Name="vc_redist.x64.exe"
            Source="$(var.ThirdPartyBinariesX64Folder)\VcRedist\vc_redist.x64.exe"
            KeyPath="yes" />
    </Component>

    <!--check / ignore-->
    <InstallExecuteSequence>
      <Custom Action="InstallVCRedist_Action_X64" After="InstallInitialize" Condition="NOT REMOVE"/>
    </InstallExecuteSequence>
    
        
    <CustomAction Id="InstallVCRedist_Action_X64"
                  FileRef="VCRedist_File_X64"
                  ExeCommand="/install /passive /norestart"
                  Return="check"
                  Execute="deferred"
                  Impersonate="no"
                  />

    <Feature Id="VCRedist_x64_Feature" Title="VC++ Redistributable (x64)" Level="1" Display="hidden" >
      <ComponentRef Id="VCRedist_Component_X64" />
    </Feature>

  </Fragment>
</Wix>

Also there is some samples how to include executable in you MSI like this: https://www.youtube.com/watch?v=lHB1hTcO2oA, but it does not reuse CA component, does not use multiple files. So it is simpler and works

Update 2024-09-06: Using
msiexec.exe /i MyInstaller_x64.msi /l*v i.txt /qb
debug command I got proper logs.
Here some log fragment with properties and failure:

Error 1721. There is a problem with this Windows Installer package. A program required for this install to complete could not be run. Contact your support personnel or package vendor. Action: InstallVCRedist_Action_X64, location: C:\Program Files\VIAVI MyApp 16.2.0.$build$ \vc_redist.x64.exe, command: /install /passive /norestart 
MSI (s) (C0:D4) [15:39:55:681]: Note: 1: 2265 2:  3: -2147287035 
MSI (s) (C0:D4) [15:39:55:682]: User policy value 'DisableRollback' is 0
MSI (s) (C0:D4) [15:39:55:682]: Machine policy value 'DisableRollback' is 0
Action ended 15:39:55: InstallFinalize. Return value 3.
MSI (s) (C0:D4) [15:39:55:684]: Note: 1: 2318 2:  
MSI (s) (C0:D4) [15:39:55:684]: Executing op: Header(Signature=1397708873,Version=500,Timestamp=1495694587,LangId=1033,Platform=589824,ScriptType=2,ScriptMajorVersion=21,ScriptMinorVersion=4,ScriptAttributes=1)
MSI (s) (C0:D4) [15:39:55:684]: Executing op: DialogInfo(Type=0,Argument=1033)
MSI (s) (C0:D4) [15:39:55:684]: Executing op: DialogInfo(Type=1,Argument=MyApp 16.2.0.$build$ )
MSI (s) (C0:D4) [15:39:55:684]: Executing op: RollbackInfo(,RollbackAction=Rollback,RollbackDescription=Rolling back action: [1],,CleanupAction=RollbackCleanup,CleanupDescription=Removing backup files File: [1],)
MSI (s) (C0:D4) [15:39:55:684]: Executing op: ActionStart(Name=InstallVCRedist_Action_X64,,)
MSI (s) (C0:D4) [15:39:55:684]: Executing op: ProductInfo(ProductKey={746F9BBE-254D-4C53-8AF2-787A15CDAB43},ProductName=MyApp 16.2.0.$build$ ,PackageName=MyAppSCMInstaller_x64.msi,Language=1033,Version=268566528,Assignment=1,ObsoleteArg=0,ProductIcon=MyAppApplicationIcon,,PackageCode={45B07B93-1EC8-446F-B752-A8872119E37D},,,InstanceType=0,LUASetting=0,RemoteURTInstalls=0,ProductDeploymentFlags=3)
MSI (s) (C0:D4) [15:39:55:684]: Executing op: End(Checksum=0,ProgressTotalHDWord=0,ProgressTotalLDWord=0)
MSI (s) (C0:D4) [15:39:55:684]: Error in rollback skipped.	Return: 5
MSI (s) (C0:D4) [15:39:55:701]: Note: 1: 2318 2:  
MSI (s) (C0:D4) [15:39:55:706]: Note: 1: 2318 2:  
MSI (s) (C0:D4) [15:39:55:707]: Calling SRSetRestorePoint API. dwRestorePtType: 13, dwEventType: 103, llSequenceNumber: 38, szDescription: "".
MSI (s) (C0:D4) [15:39:55:710]: The call to SRSetRestorePoint API succeeded. Returned status: 0.
MSI (s) (C0:D4) [15:39:55:710]: Unlocking Server
MSI (s) (C0:D4) [15:39:55:711]: PROPERTY CHANGE: Deleting UpdateStarted property. Its current value is '1'.
Action ended 15:39:55: INSTALL. Return value 3.
Property(S): ALLUSERS = 1
Property(S): MONGO_VERSION = 3
Property(S): GEOMONGOVERSIONREG = 3
Property(S): DISABLE_MONGO_VERSION_SELECTION = 0
Property(S): INSTALLATIONTYPE = GeoSCM
Property(S): ARPNOMODIFY = yes
Property(S): ARPPRODUCTICON = MyApplicationIcon
Property(S): DEFAULTINSTALLPATH = C:\Program Files\MyCompany\
Property(S): Manufacturer = I
Property(S): ProductCode = {746F9BBE-254D-4C53-8AF2-787A15CDAB43}
Property(S): ProductLanguage = 1033
Property(S): ProductName = MyApp 16.2.0.$build$ 
Property(S): ProductVersion = 16.2.0.0
Property(S): UpgradeCode = {296319BA-0AB4-4CB9-9B89-2B021E378229}
Property(S): WIXUI_INSTALLDIR = INSTALLLOCATION
Property(S): INSTALLLOCATION = C:\Program Files\MyCompany\
Property(S): DefaultUIFont = WixUI_Font_Normal
Property(S): ErrorDialog = ErrorDlg
Property(S): WixUIRMOption = UseRM
Property(S): SecureCustomProperties = ARPNOMODIFY;DISABLE_MONGO_VERSION_SELECTION;GEOCOMPLETEFOUND;GEOMONGOVERSIONREG;MONGODB_PATH;SELFFOUND;WINDOWS_BUILD_NUMBER;WIX_DOWNGRADE_DETECTED;WIX_UPGRADE_DETECTED
Property(S): MsiHiddenProperties = Wix4CommitIIS7ConfigTransaction_X64;Wix4CommitMetabaseTransaction_X64;Wix4ConfigureIIs7Exec_X64;Wix4ConfigureIIsExec_X64;Wix4RollbackIIS7ConfigTransaction_X64;Wix4RollbackMetabaseTransaction_X64;Wix4StartIIS7ConfigTransaction_X64;Wix4StartMetabaseTransaction_X64;Wix4WriteIIS7ConfigChanges_X64;Wix4WriteMetabaseChanges_X64
Property(S): MYNETFRAMEWORK472 = #533320
Property(S): WINDOWS_BUILD_NUMBER = 22631
Property(S): IISMAJORVERSION = #10
Property(S): IISMINORVERSION = #0
Property(S): ExistingFilesAction = INSTALLEDPATH=C:\Program Files\MyCompany\MyApp\Bin\
Property(S): ExistingFilesActionSCM = INSTALLEDPATH=C:\Program Files\MyCompany\MyApp SCM\Bin\
Property(S): InstalledFilesAction = INSTALLEDPATH=C:\Program Files\MyCompany\MyApp\Bin\
Property(S): InstalledFilesActionSCM = INSTALLEDPATH=C:\Program Files\MyCompany\MyApp SCM\Bin\
Property(S): INSTALLLOCATIONX86 = C:\Program Files (x86)\MyCompany\
Property(S): Wix4ConfigureIIs7Exec_X64 = **********
Property(S): Wix4StartIIS7ConfigTransaction_X64 = **********
Property(S): Wix4RollbackIIS7ConfigTransaction_X64 = **********
Property(S): Wix4CommitIIS7ConfigTransaction_X64 = **********
Property(S): Wix4WriteIIS7ConfigChanges_X64 = **********
Property(S): TARGETDIR = C:\
Property(S): BINDIRECTORY = C:\Program Files\MyCompany\MyApp\Bin\
Property(S): MyAppSCMDIRECTORY = C:\Program Files\MyCompany\MyApp SCM\
Property(S): dirC6B25E8A879A42878B7FC94A0F916808 = C:\Program Files\MyCompany\MyApp SCM\bin\
Property(S): dirF92E225B3EAF4C12827C4AF030B34404 = C:\Program Files\MyCompany\MyApp SCM\bin\en\
Property(S): dirF92E225B3EAF4C12827C4AF030B34405 = C:\Program Files\MyCompany\MyApp SCM\bin\lt\
Property(S): dirF92E225B3EAF4C12827C4AF030B3445A = C:\Program Files\MyCompany\MyApp SCM\bin\Plugins\Filters\
Property(S): GeoAnalysisWebServiceAnalyses = C:\ProgramData\MyApp\GeoAnalysisWebService\Analyses\
Property(S): SHAREDDIRECTORYX64 = C:\Program Files\MyCompany\Shared\
Property(S): dir7215B7E33310034991F932A69C29A462 = C:\Program Files\MyCompany\Shared\MapServer\bin\
Property(S): dir8205522AE0F7BE6B5748D40628AAB3F4 = C:\Program Files\MyCompany\Shared\MapServer\Fonts\
Property(S): dir684B22E1920099521B9C9A4A52984411 = C:\Program Files\MyCompany\Shared\MapServer\gdal-data\
Property(S): dirA6D17A31F3B3873857568231CCF233DD = C:\Program Files\MyCompany\Shared\MapServer\proj-data\
Property(S): INSTALLFOLDER = C:\Program Files\VIAVI MyApp 16.2.0.$build$ \
Property(S): MONGODIRECTORYX64 = C:\Program Files\MyCompany\Shared\MongoDB\
Property(S): MONGODIRECTORYX64v5 = C:\Program Files\MyCompany\Shared\MongoDBv5\
Property(S): SHAREDDIRECTORYX86 = C:\Program Files (x86)\MyCompany\Shared (x86)\
Property(S): ProgramFilesFolder = C:\Program Files (x86)\
Property(S): PLUGINS = C:\Program Files\MyCompany\MyApp\Bin\Plugins\
Property(S): GEODIRECTORY = C:\Program Files\MyCompany\MyApp\
Property(S): SCMBINDIRECTORY = C:\Program Files\MyCompany\MyApp SCM\Bin\
Property(S): SCMDIRECTORY = C:\Program Files\MyCompany\MyApp SCM\
Property(S): ProgramFiles64Folder = C:\Program Files\
Property(S): MyAppData = C:\ProgramData\MyApp\
Property(S): CommonAppDataFolder = C:\ProgramData\
Property(S): dirCFDCA2E687664EAE8F2ECE805EB2970E = C:\Program Files\MyCompany\MyApp SCM\bin\Plugins\
Property(S): GeoAnalysisWebServiceFolder = C:\ProgramData\MyApp\GeoAnalysisWebService\
Property(S): MAPSERVERDIRECTORYX64 = C:\Program Files\MyCompany\Shared\MapServer\
Property(S): SourceDir = C:\Dev\git\geo\geotrunk\Geo\MyAppInstallers\
Property(S): ProgramFiles6432Folder = C:\Program Files\
Property(S): ProgramMenuFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\
Property(S): DesktopFolder = C:\Users\Public\Desktop\
Property(S): VirtualMemory = 6149
Property(S): VersionNT = 603
Property(S): MsiLogFileLocation = C:\Dev\git\geo\geotrunk\Geo\MyAppInstallers\i2.txt
Property(S): PackageCode = {45B07B93-1EC8-446F-B752-A8872119E37D}
Property(S): ProductState = -1
Property(S): PackagecodeChanging = 1
Property(S): CURRENTDIRECTORY = C:\Dev\git\geo\geotrunk\Geo\MyAppInstallers
Property(S): CLIENTUILEVEL = 2
Property(S): CLIENTPROCESSID = 77484
Property(S): VersionDatabase = 405
Property(S): MsiSystemRebootPending = 1
Property(S): VersionMsi = 5.00
Property(S): VersionNT64 = 603
Property(S): WindowsBuild = 9600
Property(S): ServicePackLevel = 0
Property(S): ServicePackLevelMinor = 0
Property(S): MsiNTProductType = 1
Property(S): WindowsFolder = C:\WINDOWS\
Property(S): WindowsVolume = C:\
Property(S): System64Folder = C:\WINDOWS\system32\
Property(S): SystemFolder = C:\WINDOWS\SysWOW64\
Property(S): RemoteAdminTS = 1
Property(S): TempFolder = C:\Users\VIDMAN~1\AppData\Local\Temp\
Property(S): CommonFilesFolder = C:\Program Files (x86)\Common Files\
Property(S): CommonFiles64Folder = C:\Program Files\Common Files\
Property(S): AppDataFolder = C:\Users\PcUser\AppData\Roaming\
Property(S): FavoritesFolder = C:\Users\PcUser\Favorites\
Property(S): NetHoodFolder = C:\Users\PcUser\AppData\Roaming\Microsoft\Windows\Network Shortcuts\
Property(S): PersonalFolder = C:\Users\PcUser\Documents\
Property(S): PrintHoodFolder = C:\Users\PcUser\AppData\Roaming\Microsoft\Windows\Printer Shortcuts\
Property(S): RecentFolder = C:\Users\PcUser\AppData\Roaming\Microsoft\Windows\Recent\
Property(S): SendToFolder = C:\Users\PcUser\AppData\Roaming\Microsoft\Windows\SendTo\
Property(S): TemplateFolder = C:\ProgramData\Microsoft\Windows\Templates\
Property(S): LocalAppDataFolder = C:\Users\PcUser\AppData\Local\
Property(S): MyPicturesFolder = C:\Users\PcUser\Pictures\
Property(S): AdminToolsFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools\
Property(S): StartupFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Startup\
Property(S): StartMenuFolder = C:\ProgramData\Microsoft\Windows\Start Menu\
Property(S): FontsFolder = C:\WINDOWS\Fonts\
Property(S): GPTSupport = 1
Property(S): OLEAdvtSupport = 1
Property(S): ShellAdvtSupport = 1
Property(S): MsiAMD64 = 6
Property(S): Msix64 = 6
Property(S): Intel = 6
Property(S): PhysicalMemory = 32466
Property(S): AdminUser = 1
Property(S): MsiTrueAdminUser = 1
Property(S): LogonUser = PcUser
Property(S): UserSID = S-1-12-1-3068660251-1330369915-3958247324-4070418590
Property(S): UserLanguageID = 2057
Property(S): ComputerName = VD-PF4608N3
Property(S): SystemLanguageID = 1033
Property(S): ScreenX = 1024
Property(S): ScreenY = 768
Property(S): CaptionHeight = 23
Property(S): BorderTop = 1
Property(S): BorderSide = 1
Property(S): TextHeight = 16
Property(S): TextInternalLeading = 3
Property(S): ColorBits = 32
Property(S): TTCSupport = 1
Property(S): Time = 15:39:55
Property(S): Date = 9/6/2024
Property(S): MsiNetAssemblySupport = 4.8.9032.0
Property(S): MsiWin32AssemblySupport = 6.3.22621.2506
Property(S): RedirectedDllSupport = 2
Property(S): MsiRunningElevated = 1
Property(S): Privileged = 1
Property(S): DATABASE = C:\WINDOWS\Installer\29dccd19.msi
Property(S): OriginalDatabase = C:\Dev\git\geo\geotrunk\Geo\MyAppInstallers\MyAppSCMInstaller_x64.msi
Property(S): UILevel = 3
Property(S): ACTION = INSTALL
Property(S): ROOTDRIVE = C:\
Property(S): CostingComplete = 1
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
Property(S): INSTALLLEVEL = 1
Property(S): SOURCEDIR = C:\Dev\git\geo\geotrunk\Geo\MyAppInstallers\
Property(S): SourcedirProduct = {746F9BBE-254D-4C53-8AF2-787A15CDAB43}
Property(S): ProductToBeRegistered = 1
MSI (s) (C0:D4) [15:39:55:763]: Note: 1: 1708 
MSI (s) (C0:D4) [15:39:55:763]: Product: MyApp 16.2.0.$build$  -- Installation failed.

MSI (s) (C0:D4) [15:39:55:764]: Windows Installer installed the product. Product Name: MyApp 16.2.0.$build$. Product Version: 16.2.0.0. Product Language: 1033. Manufacturer: ME. Installation success or error status: 1603.

So from log looks like CustomAction is executed - and fails

4 replies

vdrasutis Sep 6, 2024
Author

Tried code below.
This one manually when installing MSI - it installs and executable I can find in Tools directory, but it is not installed as executable.
But when installing " msiexec.exe /i MySCMInstaller_x64.msi" then it fails.

<?define ThirdPartyBinariesX64Folder="..\..\..\..\ThirdpartyBinariesX64"?>

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Fragment>

    <DirectoryRef Id="SHAREDDIRECTORYX64">
      <Directory Id="TOOLSDIRECTORYX64" Name="Tools">
        <Component Id="VCRedist_Component_X64">
          <File Id="VCRedist_File_X64"
                Name="vc_redist.x64.exe"
                Source="$(var.ThirdPartyBinariesX64Folder)\VcRedist\vc_redist.x64.exe"
                KeyPath="yes" />
        </Component>
      </Directory>
    </DirectoryRef>


      <!--check / ignore-->
    <InstallExecuteSequence>
      <Custom Action="InstallVCRedist_Action_X64" After="InstallInitialize" Condition="NOT REMOVE"/>
    </InstallExecuteSequence>
    
        
    <CustomAction Id="InstallVCRedist_Action_X64"
                  FileRef="VCRedist_File_X64"
                  ExeCommand=" /install /passive /norestart"
                  Return="check"
                  Execute="deferred"
                  Impersonate="no"
                  />

    <Feature Id="VCRedist_x64_Feature" Title="VC++ Redistributable (x64)" Level="1" Display="hidden" >
      <ComponentRef Id="VCRedist_Component_X64" />
    </Feature>

  </Fragment>
</Wix>

MSI (s) (70:E8) [16:13:07:572]: Note: 1: 1721 2: InstallVCRedist_Action_X64 3: C:\Program Files\MyCompany\Shared\Tools\vc_redist.x64.exe 4: /install /passive /norestart

Thinking... Maybe CA does not handle spaces in the path?
So how I should put path in the quotes? if it is file reference...

michaelgburton Sep 6, 2024

Have you considered creating a bundle and using an approach like this instead for the VC Redistributables?

https://gist.github.com/nathancorvussolis/557d1c4faccd5c83d88be606c60430d0

michaelgburton Sep 6, 2024

I should note that you can adjust the above solution to use a local file by replacing DownloadUrl with SourceFile and removing the Hash attribute.

bevanweiss Sep 7, 2024

I think the bundle is the right way. The two choices are really to use the Merge Module, where the runtime files essentially become 'your files', or to allow the MS redistributable installer to do its thing, but then it's an installer, and you shouldn't try to run an installer from within another installer... hence the bundle. It's just an EXE with some smarts that can check for dependencies, run installers in a sequence, force rollbacks of other installers etc...

If you're needing to install multiple installers... then a bundle is the way to do this.

vdrasutis · 2024-09-09T09:45:06Z

vdrasutis
Sep 9, 2024
Author

For now I managed to fix build (after conversion with Wix CLI) using MergeFiles and build using wix v5.0.1:
So my Redistributable fragment looks like this:

"Merge" - components had to be wrapped in <DirectoryRef Id="TARGETDIR">
Also had to specify "FileSource" per each file as StandardDirectory or Component does not support this parameter as it was initially:

 <DirectoryRef Id="TARGETDIR">
   <Directory Id="System64Folder" FileSource="..\..\..\..\ThirdpartyBinariesx64\VcMergeModules">
     <Component Id="VC2022Redist" Guid="20F20857-EF99-4CED-B7E1-4094855EB3EA" Permanent="yes">

Here is working code and produces same behaviour for v4/v5 wix after migrating from v3:

<?define ThirdPartyBinariesX64_VcRedistFolder="..\..\..\..\ThirdpartyBinariesX64\VcMergeModules"?>
<?define ThirdPartyBinariesX86_VcRedistFolder="..\..\..\..\ThirdpartyBinariesX86\VcMergeModules"?>

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Fragment>
    <!-- 64 bit VC++ merge modules  v2015-2022 -->
    <FeatureGroup Id="VCRedistributable64">
      <MergeRef Id="Microsoft_VC143_CRT_x64" />
      <MergeRef Id="Microsoft_VC143_MFC_x64" />
      <MergeRef Id="Microsoft_VC143_MFCLOC_x64" />
      <MergeRef Id="Microsoft_VC143_OpenMP_x64" />
      <MergeRef Id="Microsoft_VC143_CXXAMP_x64" />

      <ComponentRef Id="VC2022Redist" />
    </FeatureGroup>

     <StandardDirectory Id="TARGETDIR">
   <Merge Id="Microsoft_VC143_CRT_x64" Language="0" SourceFile="$(var.ThirdPartyBinariesX64_VcRedistFolder)\Microsoft_VC143_CRT_x64.msm" DiskId="1" />
   <Merge Id="Microsoft_VC143_MFC_x64" Language="0" SourceFile="$(var.ThirdPartyBinariesX64_VcRedistFolder)\Microsoft_VC143_MFC_x64.msm" DiskId="1" />
   <Merge Id="Microsoft_VC143_MFCLOC_x64" Language="0" SourceFile="$(var.ThirdPartyBinariesX64_VcRedistFolder)\Microsoft_VC143_MFCLOC_x64.msm" DiskId="1" />
   <Merge Id="Microsoft_VC143_OpenMP_x64" Language="0" SourceFile="$(var.ThirdPartyBinariesX64_VcRedistFolder)\Microsoft_VC143_OpenMP_x64.msm" DiskId="1" />
   <Merge Id="Microsoft_VC143_CXXAMP_x64" Language="0" SourceFile="$(var.ThirdPartyBinariesX64_VcRedistFolder)\Microsoft_VC143_CXXAMP_x64.msm" DiskId="1" />
 </StandardDirectory>

 <StandardDirectory Id="System64Folder">
   <Component Id="VC2022Redist" Guid="20F20857-EF99-4CED-B7E1-4094855EB3EA" Permanent="yes">
     <File Id="console" Name="api-ms-win-core-console-l1-1-0.dll" Source="$(var.ThirdPartyBinariesX64_VcRedistFolder)\api-ms-win-core-console-l1-1-0.dll"/>
     <File Id="console12" Name="api-ms-win-core-console-l1-2-0.dll" Source="$(var.ThirdPartyBinariesX64_VcRedistFolder)\api-ms-win-core-console-l1-2-0.dll"/>
     <File Id="datetime" Name="api-ms-win-core-datetime-l1-1-0.dll" Source="$(var.ThirdPartyBinariesX64_VcRedistFolder)\api-ms-win-core-datetime-l1-1-0.dll"/>
     <File Id="debug" Name="api-ms-win-core-debug-l1-1-0.dll" Source="$(var.ThirdPartyBinariesX64_VcRedistFolder)\api-ms-win-core-debug-l1-1-0.dll"/>
        
      ...
        <File Id="ucrtbase" Name="ucrtbase.dll" Source="$(var.ThirdPartyBinariesX64_VcRedistFolder)\ucrtbase.dll"/>
      </Component>
    </StandardDirectory>

  </Fragment>
</Wix>

3 replies

vdrasutis Sep 9, 2024
Author

Thanks all for your answers, later will try to refactor to use bundle, sadly with custom action does not work :/ (as there less refactoring would be needed).

michaelgburton Sep 10, 2024

Just to be clear, with a bundle you wouldn't need the custom action you've shown above, as that would simply be one part of the bundle. Regardless, best of luck with it! I know it's tough to figure out; I've been struggling for days myself.

vdrasutis Sep 11, 2024
Author

After some testing - looks like my updated solution with merge files ether my MSI`s build but VC redistributable are not deployed :( . So will try to refactor to use "bundle".

vdrasutis · 2024-10-02T12:57:34Z

vdrasutis
Oct 2, 2024
Author

I was able to create new Bundle project which would include original MSI of our product and C++ Redistributable exe - basic installer worked. But... as we need to pass some parameters from bundle installer to our app installer. So decided that it is to much effort, and will go with manually or using other existing PowerShell deployment scripts to install C++ Redistributable.

1 reply

wmanning Oct 2, 2024

If by "our app installer" you mean your MSI installer you could use MsiProperty to pass in information to your MSI from the bundle. Or did you already try that?

If your app installer has a lot of GUI I guess it would be a lot of work to move the GUI from the MSI to the bundle. Ideally the bundle should contain all the GUI and pass everything to the MSI via properties using MsiProperty.

vdrasutis · 2024-10-02T13:13:50Z

vdrasutis
Oct 2, 2024
Author

Thanks @michaelgburton for idea.

Have you considered creating a bundle and using an approach like this instead for the VC Redistributables?

https://gist.github.com/nathancorvussolis/557d1c4faccd5c83d88be606c60430d0

Here is my sample of the project and using reusable component.
Note: I did changed some names - so might miss some, it is only for high view how to...

Project file:

<Project Sdk="WixToolset.Sdk/5.0.1">
  <PropertyGroup>
    <OutputType>Bundle</OutputType>
    <Platform Condition=" '$(Platform)' == '' ">x64</Platform>
    <OutputName>Installer_$(Platform)_Bundle</OutputName>
  </PropertyGroup>
  <!--<Import Project="$(SourceRoot)\GEO.Common.targets" />-->
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x64' ">
    <SourceRoot>..\..</SourceRoot>
    <PlatformName>$(Platform)</PlatformName>
    <OutputPath>$(SourceRoot)\..\MyInstallers\</OutputPath>
    <DefineConstants>SourceRoot=$(SourceRoot);MsiToBundle=$(SourceRoot)\..\MyInstallers\MyInstaller_x64.msi;MyAppVersion=$(MyAppVersion)</DefineConstants>
    <SuppressSpecificWarnings>1101</SuppressSpecificWarnings>
    <SuppressPdbOutput>True</SuppressPdbOutput>
    <SuppressIces>ICE60;ICE80</SuppressIces>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="..\Common\Components\VCRedistributables.wxs" Link="VCRedistributables.wxs" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="WixToolset.Bal.wixext" Version="5.0.1" />
    <PackageReference Include="WixToolset.Util.wixext" Version="5.0.1" />
  </ItemGroup>
</Project>

Bundle.wxs:

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs"
  xmlns:bal="http://wixtoolset.org/schemas/v4/wxs/bal"
  xmlns:util="http://wixtoolset.org/schemas/v4/wxs/util">

  <?define name = "MY Bundle"?>
  <?define path = "D:\Downloads\"?>
  <?define version = "1.1.10.0"?>
  <?define publisher = "HELLO WORLD"?>
  <?define guid = "111309bc-0haa-1ca9-9b29-2a021e371129"?>
  <?define manufacturer = "VIAVI"?>

  <Bundle Name="$(var.name)" Manufacturer="$(var.manufacturer)" Version="$(var.version)" UpgradeCode="$(var.guid)">
    <BootstrapperApplication >
      <bal:WixStandardBootstrapperApplication 
        LicenseUrl="" 
        Theme="hyperlinkSidebarLicense" 
        SuppressOptionsUI="true"
        ShowVersion="yes" />
    </BootstrapperApplication>
     
    <Chain>
      <PackageGroupRef Id="VCRedist_x64_Package"/>
      
      <MsiPackage Id="MY_MSI" After="VCRedist_x64" SourceFile="$(var.MsiToBundle)" Vital="true" 
                  InstallCondition="NOT Installed" EnableFeatureSelection="yes">
      </MsiPackage>
    </Chain>

  </Bundle>
  
</Wix>

Common/Components/VCRedistributables.wxs:

<?define ThirdPartyBinariesX64_VcRedistFolder="..\..\..\..\ThirdpartyBinariesX64\VcRedist" ?>
<?define VcRedistVersionToInstall="14.38.33135.0" ?>

<Wix 
  xmlns="http://wixtoolset.org/schemas/v4/wxs" 
  xmlns:bal="http://wixtoolset.org/schemas/v4/wxs/bal" 
  xmlns:util="http://wixtoolset.org/schemas/v4/wxs/util">
  
  <Fragment>
    <util:RegistrySearch
      Id="REG_ARCH"
      Root="HKLM"
      Key="SYSTEM\CurrentControlSet\Control\Session Manager\Environment"
      Value="PROCESSOR_ARCHITECTURE"
      Result="value"
      Variable="ARCH_NAME" />
    
    <!-- Visual C++ 2015-2022 Redistributable (x64) runtime minimum msi package version -->
    <util:ProductSearch
      Id="VCRUNTIME_X64"
      Result="version"
      Variable="VCRUNTIME_X64_VER"
      UpgradeCode="36F68A90-239C-34DF-B58C-64B30153CE35"
      Condition="VersionNT64 AND (ARCH_NAME = &quot;AMD64&quot;)"
      After="REG_ARCH" />
    
    <!-- InstallSize="0"  - Exclude VC executable files from package size calcualtion -->
    <PackageGroup Id="VCRedist_x64_Package">
      <ExePackage
          Id="VCRedist_x64"
          Name="vcredist_x64.exe"
          PerMachine="yes"
          SourceFile="$(var.ThirdPartyBinariesX64_VcRedistFolder)\$(var.VcRedistVersionToInstall)\VC_redist.x64.exe"
          InstallArguments="/install /quiet /norestart"
          Bundle="yes"
          InstallSize="0"
          Permanent="yes"
          Vital="yes"
          DetectCondition="VCRUNTIME_X64_VER &gt;= v$(var.VcRedistVersionToInstall)"
          InstallCondition="NOT (VCRUNTIME_X64_VER &gt;= v$(var.VcRedistVersionToInstall))"
          /> 
    </PackageGroup>
    
  </Fragment>

</Wix>

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WiX Toolset

How to create reusable element and install VC Redistributables (c++) before installing my app(s) by referencing in multiple products #8735

{{title}}

Replies: 4 comments 8 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

WiX Toolset

How to create reusable element and install VC Redistributables (c++) before installing my app(s) by referencing in multiple products #8735

vdrasutis Sep 5, 2024

Replies: 4 comments · 8 replies

vdrasutis Sep 5, 2024 Author

vdrasutis Sep 6, 2024 Author

michaelgburton Sep 6, 2024

michaelgburton Sep 6, 2024

bevanweiss Sep 7, 2024

vdrasutis Sep 9, 2024 Author

vdrasutis Sep 9, 2024 Author

michaelgburton Sep 10, 2024

vdrasutis Sep 11, 2024 Author

vdrasutis Oct 2, 2024 Author

wmanning Oct 2, 2024

vdrasutis Oct 2, 2024 Author

vdrasutis
Sep 5, 2024

Replies: 4 comments 8 replies

vdrasutis
Sep 5, 2024
Author

vdrasutis Sep 6, 2024
Author

vdrasutis
Sep 9, 2024
Author

vdrasutis Sep 9, 2024
Author

vdrasutis Sep 11, 2024
Author

vdrasutis
Oct 2, 2024
Author

vdrasutis
Oct 2, 2024
Author