NULL_POINTER_READ_c0000005_SystemInformer.exe!PhAddIListViewColumn

[MagicAndre1981]

Brief description of your issue

I tried to open GraphicsDeviceDetails on Win 11 24H2 and Si crashed:

 # Child-SP          RetAddr               Call Site
00 000000b5`d10ff0d0 00007ffd`7af0be50     SystemInformer!PhAddIListViewColumn(struct IListView * ListView = 0x00000000`00000000, long Index = 0n0, long DisplayIndex = 0n0, long SubItemIndex = 0n0, long Format = 0n0, long Width = 0n230, wchar_t * Text = 0x00007ffd`7af409c0 "Property")+0x28 [phlib\guisuplistview.cpp @ 112] 
01 000000b5`d10ff180 00007ffd`afe10f00     HardwareDevices!GraphicsDeviceDetailsDlgProc(struct HWND__ * hwndDlg = 0x00000000`000904e8, unsigned int uMsg = <Value unavailable error>, unsigned int64 wParam = 0xa0472, int64 lParam = 0n2508154927936)+0x370 [plugins\HardwareDevices\gpudetails.c @ 382] 
02 000000b5`d10ff210 00007ffd`afe0f454     user32!UserCallDlgProcCheckWow+0x1e4
03 000000b5`d10ff300 00007ffd`afe0f376     user32!DefDlgProcWorker+0xc4
04 000000b5`d10ff3b0 00007ffd`afe15801     user32!DefDlgProcW+0x36
05 000000b5`d10ff3f0 00007ffd`afe14b23     user32!UserCallWinProcCheckWow+0x341
06 000000b5`d10ff550 00007ffd`afe1eb29     user32!SendMessageWorker+0x223
07 000000b5`d10ff600 00007ffd`afe1df27     user32!InternalCreateDialog+0xa69
08 000000b5`d10ff7e0 00007ffd`afe1f4a8     user32!CreateDialogIndirectParamAorW+0x57
09 000000b5`d10ff830 00007ff6`dc4392b2     user32!CreateDialogIndirectParamW+0x18
0a 000000b5`d10ff870 00007ffd`7af0bffb     SystemInformer!PhCreateDialog(void * Instance = 0x00007ffd`7af00000, wchar_t * Template = <Value unavailable error>, struct HWND__ * ParentWindow = 0x00000000`000d0358, <function> * DialogProc = 0x00007ffd`7af0bae0, void * Parameter = 0x00000247`f9aefb40)+0x92 [phlib\guisup.c @ 1561] 
0b 000000b5`d10ff910 00007ff6`dc42a735     HardwareDevices!GraphicsDeviceDetailsDialogThreadStart(void * Parameter = 0x00000247`f9aefb40)+0x7b [plugins\HardwareDevices\gpudetails.c @ 543] 
0c 000000b5`d10ffbc0 00007ffd`af72dbe7     SystemInformer!PhpBaseThreadStart(void * Parameter = <Value unavailable error>)+0x75 [phlib\basesup.c @ 195] 
0d 000000b5`d10ffc00 00007ffd`b07ffbec     kernel32!BaseThreadInitThunk+0x17
0e 000000b5`d10ffc30 00000000`00000000     ntdll!RtlUserThreadStart+0x2c

Here is the calling code before crash:

Steps to reproduce (optional)

No response

Expected behavior (optional)

No response

Actual behavior (optional)

No response

Environment (optional)

3.2.25004.614
Windows 11 24H2 x64

[ge0rdi]

Looks like the bug was introduced in f8757ab.

That commit added context->ListViewClass = PhGetListViewInterface(hwndDlg); line.
But there should be context->ListViewHandle passed instead of hwndDlg.

[MagicAndre1981]

works fine with 3.2.25011.2103 (bfbd659)