fix crash dialog dismiss behavior

[ge0rdi]

When crash dialog was dismissed (escape, close dialog), PhShowTaskDialog returned IDCANCEL which value (2) was the same as value for "Normal" dump button.

It was probably not expected to create crash dump when user dismissed the dialog.

So we will use distinct values for custom dialog buttons.

[ge0rdi]

One more thing related to crash dialog.
It seems many users create mini dumps that contain just bare amount of information.

Shouldn't we somehow encourage them to create at least normal dump?
We can make that button default.
Or add information that this is preferred.

What do you think?

[jxy-s]

One more thing related to crash dialog. It seems many users create mini dumps that contain just bare amount of information.

Shouldn't we somehow encourage them to create at least normal dump? We can make that button default. Or add information that this is preferred.

What do you think?

I think the default is appropriate (exit without collecting a dump). I would prefer at least a normal dump from crashes. I think the encouragement "this dump file is the most useful" is probably reasonable as it is. I'm not sure if adding "preferred" is a substantial nudge over what is already there.