Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in Higgs mass calculation #57

Closed
JoseEliel opened this issue Dec 15, 2020 · 10 comments
Closed

Possible bug in Higgs mass calculation #57

JoseEliel opened this issue Dec 15, 2020 · 10 comments
Labels
bug Something isn't working

Comments

@JoseEliel
Copy link

JoseEliel commented Dec 15, 2020

In the function m2Lambda_to_vMh2 (defined in line 38 of smpar.py) the Higgs mass formula

    Mh2 = 2 * m2 * (1 - m2 / Lambda * (3 * C['phi'] - 4 * Lambda * C['phiBox'] +
                                        Lambda * C['phiD']))

seems to have a typo. Comparing with the expression from https://arxiv.org/abs/1704.03888, there should be a Lambda^2 term in the factor multiplying the second parenthesis, i.e. it should be

Mh2 = 2 * m2 * (1 - m2 / (Lambda*Lambda) * (3 * C['phi'] - 4 * Lambda * C['phiBox'] + 
                                       Lambda * C['phiD']))

@DavidMStraub
Copy link
Member

Oh. I don't see why this would not be a bug, indeed.

Does changing that solve #52?

@DavidMStraub DavidMStraub added the bug Something isn't working label Dec 15, 2020
@JoseEliel
Copy link
Author

No, I have just checked. I think they are unrelated issues.

@DavidMStraub
Copy link
Member

Waiting for @peterstangl or @jasonaebischerGIT to confirm.

Then it would be great if you can submit a PR (but please use **2, this is not Fortan 😉)

@JoseEliel
Copy link
Author

I will. Good point on **2, I'm often writing C++ (luckily not Fortran 😉 ), so that's where that came from.

@jasonaebischerGIT
Copy link
Collaborator

... there should be a Lambda^2 term in the factor multiplying the second parenthesis, i.e. it should be

Mh2 = 2 * m2 * (1 - m2 / (Lambda*Lambda) * (3 * C['phi'] - 4 * Lambda * C['phiBox'] + 
                                       Lambda * C['phiD']))

I agree, this formula is correct.

JoseEliel added a commit to JoseEliel/wilson that referenced this issue Dec 21, 2020
Added factor of 1/lambda missing in the Higgs mass calculation. See Issue wilson-eft#57: wilson-eft#57
@JoseEliel
Copy link
Author

I've made the pull request.

@jasonaebischerGIT
Copy link
Collaborator

The check from travis seems to have failed. Not sure what the origin of this is...

@celis
Copy link

celis commented Dec 22, 2020

from the travis logs it seems one needs to reduce the numerical accuracy (places argument) required in the assertAlmostEqual method.

@peterstangl
Copy link
Collaborator

This issue should be solved by the new PR #59 and I think PR #58 can be closed.

BTW: Fortran actually does implement the ** exponentiation operator. So this seems to be just an issue with C/C++ 😉
(that's why one can get relatively nice expressions that work in Python from Mathematica's FortranForm)

@jasonaebischerGIT
Copy link
Collaborator

Closing this issue, which is resolved by PR #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants