Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect threshold value for tmax to intensity ratio for sigmoidal fit #3

Open
empetroni opened this issue Jul 2, 2020 · 1 comment

Comments

@empetroni
Copy link

empetroni commented Jul 2, 2020

In the "categorize.R" function, I noticed that on line 157, when the function checks to see if the tmax to intensity ratio for a sigmoid curve is above the threshold value, the threshold value for double sigmoidal is used instead of the threshold for sigmoidal.
From the function:
decisionList$test.sm_tmax_IntensityRatio <- decisionList$sm_tmax_IntensityRatio > threshold_dsm_tmax_IntensityRatio

@clauswilke
Copy link
Contributor

Yes, looks that way. Feel free to submit a pull request to fix this. If you do, please also adjust the default value for threshold_sm_tmax_IntensityRatio so behavior of the package doesn't actually change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants