From 62a23f679d1b67b2b3c189e57b6bb2dd8c5d3d5f Mon Sep 17 00:00:00 2001 From: Claus Wilke Date: Thu, 14 Sep 2017 21:45:46 -0500 Subject: [PATCH] update cran comments --- cran-comments.md | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 0dfb40a..f97cbec 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,6 +1,5 @@ -Apologies for submitting a bug-fix release 1 day after submitting the original package. The package currently on CRAN doesn't build on some architectures, due to visual tests that are likely to fail due to minor changes in the build platform: https://cran.r-project.org/web/checks/check_results_ggridges.html - -These tests should be automatically skipped but apparently that isn't happening. So I'm now manually disabling them on CRAN. +Apologies for submitting a bug-fix release 1 day after submitting the original package. The package currently on CRAN doesn't build on some architectures, due to failing visual tests: https://cran.r-project.org/web/checks/check_results_ggridges.html +Visual tests (via vdiffr) are known to be highly dependent on minor changes in the build platform and thus should be skipped whenever there are any changes. This should have happened automatically but apparently has not. So I have now manually disabled these tests when building on CRAN. I have also fixed the problem with double spaces in the Description. @@ -14,13 +13,7 @@ for completeness. * local OS X install x86_64-apple-darwin15.6.0 (64-bit), R 3.4.1 ## R CMD check results -There were no ERRORs or WARNINGs. - -There was one Note: -Possibly mis-spelled words in DESCRIPTION: - Ridgeline (3:8, 8:14) - -The spelling is correct. +There were no ERRORs, WARNINGs, or NOTEs. ## Downstream dependencies None at this time.