-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec for toggleAttribute could be a bit clearer #3779
Labels
clarification
Standard could be clearer
Comments
I can likely tackle this at the same time of the following bug: whatwg/dom#657. Thanks for the feedback! |
@bzbarsky does whatwg/dom#663 solve this? |
It's a step in the right direction, but it still has the run-on "then" clauses instead of just breaking out its steps into a numbered list. |
Ah sorry I missed that thanks, fixing now. |
Updated and also moved out this attribute creation into it's own concept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current spec does this:
If attribute is null, then:
Note the need for a bunch of "then" in the first nested case. This might be easier to read as:
If attribute is null, then:
If force is given and is false, return false.
Create an attribute whose local name is qualifiedName, value is the empty string, and node document is the context object’s node document.
Append this attribute to the context object.
Return true.
or so. Similar for the case when attribute is not null.
The text was updated successfully, but these errors were encountered: