Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry option to download command #28

Open
wsnoble opened this issue Sep 9, 2022 · 2 comments
Open

Add retry option to download command #28

wsnoble opened this issue Sep 9, 2022 · 2 comments

Comments

@wsnoble
Copy link

wsnoble commented Sep 9, 2022

I am finding that downloading from PRIDE is pretty flakey, and the download command fails in about 10-25% of the runs. I have written my own wrapper code to detect this, wait for 60 seconds, and then retry the download (up to n time). I think you might want to consider adding this functionality to ppx.

@wfondrie
Copy link
Owner

wfondrie commented Sep 9, 2022

I've experienced this problem as well. Currently, ppx will already retries connecting up to 10 times, although there is no delay between the attempts.

I'm not sure how helpful it would be to expose this parameter, but it might be helpful to add a delay between the attempts. What do you think Bill?

@wsnoble
Copy link
Author

wsnoble commented Sep 9, 2022

I think adding a delay is worth doing.

I didn't know it was already retrying 10 times. Is this shown in the progress bar in some way? It seems like user-level indication of this behavior would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants