Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in reversing peptides with PeptideTokenizer.detokenize #58

Open
andradesalazar opened this issue Jun 21, 2024 · 0 comments
Open

Comments

@andradesalazar
Copy link

Hi all,

Detokenizing peptides with mods e.g. PEP+79.996 with let's say reversed tokenized tensor [1,2,3] is not returning the expected behavior. In the current implementation here https://github.com/wfondrie/depthcharge/blob/main/depthcharge/tokenizers/peptides.py#L201
The tokens [1,2,3] get first detokenized and joined to P+79.996EP before getting reversed to PEP69.97+P which is then returned. I think they should be first detokenized without joining (i.e. join=False in detokenize()), then reversed, finally joined.

Best,
Daniela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant