Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail to invalid spectra warning parsers.py #41

Open
melihyilmaz opened this issue Nov 20, 2023 · 1 comment
Open

Add detail to invalid spectra warning parsers.py #41

melihyilmaz opened this issue Nov 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@melihyilmaz
Copy link
Collaborator

Warning should include why the spectra were invalid e.g. WARNING: Skipped 6745 spectra with invalid charge > 5.

@melihyilmaz melihyilmaz added the enhancement New feature or request label Nov 20, 2023
@wsnoble
Copy link

wsnoble commented Nov 25, 2023

Follow-up comment from Wout: "It can be any reason, including invalid charge, but also other issues encountered during parsing and preprocessing, such as an insufficient number of peaks. Considering that we report spectra as skipped if there's an exception thrown in the parsing/preprocessing without any way to record why those spectra are skipped, unfortunately it's not as simple as just providing more details in the log message."

That said, I think it would still be a good idea to provide this info, though I understand it might require some bookkeeping to track the counts for the various reasons a spectrum might be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants