-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embedded STL viewer #83
Comments
I found one here. That might make it a bit more viable. |
@ke7ofi Neat idea! Right now, the code that handles embedding different types of media lives in the webtorrent package at lib/append-to.js. I think that putting STL support there might drastically increase the size of the currently small webtorrent js bundle. But adding it to instant.io is a great idea! I couldn't see any source code for ViewSTL at your link and we don't want to just iframe a third party service. That's not secure or private, and they don't even support SSL so there would be mixed content errors. We need something that's open source that we can include. |
@maxogden has an old package that might work, or make a good starting point: https://www.npmjs.com/package/stl-obj-viewer |
demo http://maxogden.github.io/stl-obj-viewer/ On Fri, Aug 28, 2015 at 11:25 AM, Feross Aboukhadijeh <
|
@feross Is there any way of telling append-to.js to “pipe” it to some other program, or does it have to be fairly integrated? This seems like a case where the Unix approach would be better in the long term as you add more filetypes. |
@maxogden nice! |
@ke7ofi Yes, there's already an API to pipe files to arbitrary destinations. See For the most common case of appending video, audio, or images to the DOM, I think it's nice to have built-in support for now. But we should eventually publish it as a separate npm package and maybe remove support from core to keep it lean and simple... And there should be a way to extend what file formats |
GitHub uses one, though I can’t find the source. Would it be difficult to add one?
The text was updated successfully, but these errors were encountered: