Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev dependencies should be separated from normal dependencies #17

Open
phiresky opened this issue Mar 14, 2022 · 0 comments
Open

Dev dependencies should be separated from normal dependencies #17

phiresky opened this issue Mar 14, 2022 · 0 comments

Comments

@phiresky
Copy link

phiresky commented Mar 14, 2022

Right now, the setup.py file specifies that the dependencies should be loaded from requirements.txt. But the requirements.txt file specifies things like black, which are not actually needed when installing wacz as a dependency.

This means that if you have a program that needs on a current version of black you cannot add wacz as a dependency due to soemthing like this error from pip:

ERROR: Cannot install <depender> because these package versions have conflicting dependencies.
The conflict is caused by:
    black 22.1.0 depends on click>=8.0.0
    nltk 3.7 depends on click
    wacz 0.3.2 depends on click<7.2.0 and >=7.1.1

I don't know what the most "pythonic" solution to this is (except using pyproject.toml instead of setup.py), but in general wacz should not depend on black as a library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant