Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLOBAL:rsync:exclude-Settings like - ".git**" will be ignored by deploy command #60

Open
ghost opened this issue Aug 19, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 19, 2015

Exclude settings in the deploy section are ok.

@mblaschke
Copy link
Member

Which ct version ct --version?
Please check exclude settings with ct sync:deploy --config

@josefglatz
Copy link
Member

I already figured out some irregularities. But couldn't find out the reason.

@josefglatz
Copy link
Member

Hallo! I'm actually writing a clisync.yml and I think that there's a bug on how the exclude's get's merged/overridden. Maybe @mblaschke you've got an idea?

GLOBAL.rsync.exclude contains:

            - "*~"
            - "._*"

            # VCS
            - ".git*"
            - ".svn*"

            # Build files
            - "composer.json"
            - "bower.json"
            - "gulpfile.js"
            - "Gruntfile.js"
            - "Makefile"

            # Caches and other files
            - "node_modules"
            - ".sass-cache"
            - ".settings"
            - ".bowerrc"
            - ".buildpath"
            - ".project"

            # Additional project specific files
            - ".DS_Store"
            - "bower_components"
            - "*.log"
            - "/web/typo3temp"
            - "/web/fileadmin/_processed_/**"
            - "/web/fileadmin/_temp_/**"
            - "ENABLE_INSTALL_TOOL"
            - "FIRST_INSTALL"
            - "realurl_autoconf.php"
            - "AdditionalConfiguration_custom.php"
            - "AdditionalConfiguration_Development_Docker.php"
            - "/Build"

If I configure deploy.GLOBAL.rsync.exclude like:

                - "/web/uploads/"
                - "/web/typo3conf/l10n/"

...the final exclude array (via --config cmdline option) results in:

                    [1] => /web/uploads/
                    [2] => /web/typo3conf/l10n/
                    [3] => .svn*
                    [4] => composer.json
                    [5] => bower.json
                    [6] => gulpfile.js
                    [7] => Gruntfile.js
                    [8] => Makefile
                    [9] => node_modules
                    [10] => .sass-cache
                    [11] => .settings
                    [12] => .bowerrc
                    [13] => .buildpath
                    [14] => .project
                    [15] => .DS_Store
                    [16] => bower_components
                    [17] => *.log
                    [18] => /web/typo3temp
                    [19] => /web/fileadmin/_processed_/**
                    [20] => /web/fileadmin/_temp_/**
                    [21] => ENABLE_INSTALL_TOOL
                    [22] => FIRST_INSTALL
                    [23] => realurl_autoconf.php
                    [24] => AdditionalConfiguration_custom.php
                    [25] => AdditionalConfiguration_Development_Docker.php
                    [26] => /Build

I didn't found the logic on how this is merged. It feels like a bug? What do you mean?

[1:53]
I'm excepting that deploy.GLOBAL.rsync.exclude overrides only same lines.

[1:53]
Is this a false assumption of mine?

[1:56]
The problem occurs also if I use deploy.production-dev.rsync.exclude for example instead of deploy.GLOBAL.rsync.exclude (edited)

Josef Glatz [2:06 PM]
It seems like, that merging context > sync.GLOBAL/deploy.GLOBAL/share.GLOBAL > GLOBAL doesn't work as expected. instead of really merging/overriding it "just" overwrites from the beginning of upper configurations

josefglatz pushed a commit to josefglatz/TYPO3-Distribution that referenced this issue Jun 26, 2017
Add default LOCAL.mysql.dockercompose setting
for docker-compose supported webdevops/clitools versions.

Set common GLOBAL.rsync.workdir value.

Add my common rsync exclude's which aren't part of
the official webdevops clisync.yml file in different
places of the file.

Assume that the local dev environment is a macOS
system und set file system specific utf8 stuff therefore
in GLOBAL.rsync.opts.

Add common environments with some useful defaults
and finalize commands for users using iTerm.app.

Set global sync excludes.

!!! Take care until the merging of exclude(/directory) does not work
as expected within webdevops/clitools. Some excludes
aren't working as expected.

ToDo's
- Finalize after webdevops/clitools#60 is fixed
- Document rsync workarounds
- Add more useful finalize commands after deploy/sync as comment to clisync.yml
- take care of the share configuration
- Add docu how to do a initial deployment (db, assets)

Related: #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants