Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track titles with multiple suffixes #103

Open
djmattyg007 opened this issue Jan 1, 2021 · 2 comments
Open

Track titles with multiple suffixes #103

djmattyg007 opened this issue Jan 1, 2021 · 2 comments

Comments

@djmattyg007
Copy link
Contributor

djmattyg007 commented Jan 1, 2021 •
edited
Loading

I've come across a track title on Spotify that is literally Fa Fa Fa - (Album Version). The removeVersion filter correctly strips (Album Version), leaving it as Fa Fa Fa - . However, I'm not aware of a filter that will strip the - at present.

It's also worth noting that the predefined Spotify filter doesn't currently strip version suffixes like this. I'd like to submit a PR to add it, unless you have an objection.
@djmattyg007
Copy link
Contributor Author

djmattyg007 commented Jan 1, 2021 •
edited
Loading

Actually, I remembered the TRIM_SYMBOLS_FILTER_RULES set of filters, which looks like it would be sufficient. Perhaps these should both be added to the predefined Spotify filter at the same time?

@alexesprit
Copy link
Member

Yes, it could be reused in Spotify filter to process such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djmattyg007 @alexesprit