Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UI for which repo to apply template is non-deterministic #2583

Closed
kingdonb opened this issue Mar 22, 2023 · 1 comment · Fixed by #2731
Closed

The UI for which repo to apply template is non-deterministic #2583

kingdonb opened this issue Mar 22, 2023 · 1 comment · Fixed by #2731
Assignees
Labels
bug_release bugs found in a specific release team/pesto

Comments

@kingdonb
Copy link
Contributor

WGE release: 0.19.0

Kubernetes release:
v1.26.1+k3s1

Priority

  • low
  • medium
  • high

Severity

  • low
  • medium
  • high
  • critical

Describe the bug
When I am using a template, one of the selection options is which Git Repo to apply my PR to. My cluster was bootstrapped outside of fleet-infra, I don't know if this is related, but it randomly chooses one of bootstrap-repo and fleet-infra. The order in the git repo dropdown box also randomly re-asserts itself while you are selecting your choice, if you wait just a few seconds it will do it again.

This is jarring and sort of unsettling behavior from the UI, compounded on the fact that sometimes my PR will randomly fail because it targeted the wrong repository. I do not know if it would help if I have set the repositoryUrl here:

https://github.com/kingdon-ci/fleet-infra/blob/adc7ed9a379f34f0845385a4e98ba16a66df98c6/examples/weave-gitops/weave-gitops-enterprise.yaml#L92-L96

I'm thinking there might be more than one UX issue here. Please advise.

To Reproduce
A repro is on the mccp.howard.moomboo.space instance - if there's anything unclear about the reproduction I can provide more details.

Actual behaviour

Expected behaviour
The management repo should always be selected first, and the order in the dropdown box should not rearrange while you are selecting.

Cloud provider:

  • VCluster

Additional context

@kingdonb kingdonb added team/pesto bug_release bugs found in a specific release labels Mar 22, 2023
@foot
Copy link
Collaborator

foot commented Apr 4, 2023

Could be either:

  • Failure to list all sources on some polls known issue
  • "default" repo is only selected by (ns/name:flux-system/flux-system) and doesn't include the cluster, so could flip flop between multiple here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug_release bugs found in a specific release team/pesto
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants