Memory allocation in identity_matrix (more generally, diagonal_matrix)

[a-kulkarn]

using Oscar
Qp = PadicField()
I = identity_matrix(QQ, 5)
I[1,1] === I[2,2] # evaluates to false

Ip = identity_matrix(Qp, 5)
Ip[1,1] === Ip[2,2] # evaluates to true

I think the abstract type implementation for identity_matrix might need a deepcopy, or a note in the documentation.

[wbhart]

The official repository is here:

https://github.com/Nemocas/AbstractAlgebra.jl/

[a-kulkarn]

Ah, thanks. Should I make a PR there as well?

…

On Thu, Jan 27, 2022, 17:37 wbhart ***@***.***> wrote: The official repository is here: https://github.com/Nemocas/AbstractAlgebra.jl/ — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHEEZKLOQIXAVQHQENLX7JTUYG75TANCNFSM5M7DMCWA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[wbhart]

Sure. But you might want to discuss the behaviour there first. I'm not sure anyone thinks that is broken.