Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure watertap as an optional dependency #7

Open
lbianchi-lbl opened this issue Oct 10, 2024 · 0 comments
Open

Configure watertap as an optional dependency #7

lbianchi-lbl opened this issue Oct 10, 2024 · 0 comments
Assignees

Comments

@lbianchi-lbl
Copy link
Contributor

  • If/when Moving cyipopt solver adapter code from watertap-org/watertap to this repository #6 is complete, reaktoro-pse will cease depending on watertap as a required dependency
  • However, we'll likely still rely on importing watertap for non-essential purposes, such as Jupyter notebooks
  • Therefore, we need to set things up so that:
    • watertap is available and can be installed easily where needed (e.g. by bundling it together with the Jupyter dependencies so that they can all be installed in the environment(s) where the notebooks are run)
    • Everything else works (i.e. there are no test failures) if watertap is not importable
    • This will most likely require adding another CI check branch so that tests are run in environments both with and without watertap installed
@lbianchi-lbl lbianchi-lbl self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant