Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign message with Wallet #881

Open
raze-sag opened this issue Jan 14, 2025 · 7 comments · May be fixed by #882
Open

Sign message with Wallet #881

raze-sag opened this issue Jan 14, 2025 · 7 comments · May be fixed by #882
Assignees
Labels
enhancement New feature or request

Comments

@raze-sag
Copy link

Hello,

I would like to know whether there is an endpoint in the Wallet API for solving cryptographic challenges, for example, to sign a specific message with the private key of a user's key.

Use Case

In my use case, I want to implement client-sided encryption.
I would therefore like to send a message to the users wallet, which the user has to sign with his private key and return it so that I can use the signed message as a stable seed for generating a cryptographic key.

As I was unable to find such an endpoint in the OpenAPI and would therefore like to know what would be the best approach to solving this issue.

Thank you for your help!

@raze-sag raze-sag added the bug Something isn't working label Jan 14, 2025
@walt-id walt-id deleted a comment Jan 14, 2025
@SuperBatata SuperBatata self-assigned this Jan 14, 2025
@SuperBatata SuperBatata added enhancement New feature or request and removed bug Something isn't working labels Jan 14, 2025
@SuperBatata
Copy link
Contributor

Thank you @raze-sag for your suggestion and detailed use case! We're happy to let you know that we’ve started working on implementing this feature to allow signing messages with a user’s private key directly through the Wallet API. This will help enable use cases like client-side encryption and cryptographic challenge solving. The feature will be available soon, and we’ll keep you updated on the progress.

Thanks again for your valuable feedback! 😊

@raze-sag
Copy link
Author

Great to hear that you are already working on that.
I'd love to help you testing this feature if you already have an early implementation for that endpoint.

@SuperBatata SuperBatata linked a pull request Jan 14, 2025 that will close this issue
5 tasks
@raze-sag
Copy link
Author

Thanks a lot, that's quick

@alegomes
Copy link
Contributor

alegomes commented Jan 15, 2025

Thanks for your report, @raze-sag !

If you believe that our product is of some value to the world and that we are doing a good job, would it be daring of me to ask you for a lousy little star in the repository? 😇

@raze-sag
Copy link
Author

@alegomes of course, thanks for reminding!

@raze-sag
Copy link
Author

raze-sag commented Jan 15, 2025

Just a small follow up question @SuperBatata ,

I have just checked out the branch and built the corresponding images to test the signing feature. And as I understand it, the data flow for signing a message is as follows:

01

This works in a scenario in which I host a web application and Walt.id including the wallet.

Would it be possible to realize a data flow in which a QR code is generated like the /openid4vc/verify endpoint of the verifier, which the user scans, selects the corresponding key to sign the message?

I hope that that's some how understandable😅

@SuperBatata
Copy link
Contributor

Thank you for the follow-up question @raze-sag and for testing the signing feature! 😊

We appreciate your suggestion regarding a QR-code-based flow similar to the /openid4vc/verify endpoint. This is a great idea and a very interesting use case. While we won't be developing it right now, we’ve added it to our backlog for future consideration.

Thanks again for sharing your ideas and helping us improve—feedback like yours is invaluable! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants