Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: Tracing #194

Open
xBlaz3kx opened this issue Nov 26, 2024 · 2 comments
Open

Feature proposal: Tracing #194

xBlaz3kx opened this issue Nov 26, 2024 · 2 comments

Comments

@xBlaz3kx
Copy link
Contributor

xBlaz3kx commented Nov 26, 2024

Hey!

Since this library is a nice, simplified wrapper arround the official amqp library, it would make sense to also support observability using OpenTelemetry out of the box (of course, it would be optional).

I have already implemented this in my own personal development library, but It would make sense to also include it here. I would like to know your thoughts if this is a possibility and how we could approach this idea/implementation.

@thibleroy
Copy link

thibleroy commented Jan 14, 2025

As mentioned here, I do not think this will be done using otel packages. It is very easy to instrument your publish/consume using a custom wrapper (i.e. injecting and retrieving trace/span ids in amqp message headers)

@xBlaz3kx
Copy link
Contributor Author

As mentioned here, I do not think this will be done using otel packages. It is very easy to instrument your publish/consume using a custom wrapper (i.e. injecting and retrieving trace/span ids in amqp message headers)

I am aware that the goal is to keep dependencies to a minimum and that instrumenting is easy. Im just pointing out that it would be nice to do so in a simplified/standardized way, so it works out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants