Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): support relative link in RouteLink #1545

Merged
merged 18 commits into from
May 13, 2024
Merged

feat(client): support relative link in RouteLink #1545

merged 18 commits into from
May 13, 2024

Conversation

Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9061104366

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 41.959%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/client/src/router/resolveRoute.ts 0 1 0.0%
packages/client/src/router/resolveRoutePath.ts 0 2 0.0%
packages/client/src/components/RouteLink.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 9057705836: 0.02%
Covered Lines: 689
Relevant Lines: 1688
💛 - Coveralls

@Mister-Hope
Copy link
Member Author

Mister-Hope commented May 13, 2024 •
edited
Loading

ping @meteorlxy

@Mister-Hope
Copy link
Member Author

Why is the e2e test failing again... 😒😒

@meteorlxy meteorlxy merged commit 7c8f271 into main May 13, 2024
21 checks passed
@meteorlxy meteorlxy deleted the route-link branch May 13, 2024 10:15
@meteorlxy meteorlxy mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mister-Hope @coveralls @meteorlxy