feat(shared): support relative links in normalizeRoutePath #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9041425565Details
💛 - Coveralls |
meteorlxy
reviewed
Apr 16, 2024
meteorlxy
reviewed
Apr 17, 2024
meteorlxy
previously approved these changes
Apr 19, 2024
meteorlxy
reviewed
Apr 19, 2024
| [['.md'], '.html'], | ||
| [['foo/.md'], 'foo/.html'], | ||
| [['/.md'], '/.html'], | ||
| [['/foo/.md'], '/foo/.html'], |
There was a problem hiding this comment.
Still need cases with current for the last 5 lines
There was a problem hiding this comment.
I actually don't think this is needed, These are corner cases which we are not expecting users to actually set them in production. I don't think those can be valid links
There was a problem hiding this comment.
They are unexpected, but still should be covered by our unit tests
There was a problem hiding this comment.
For example, if a method is going to throw an error with unexpected input, we usually test it with expect().toThrow(). For this case, we don't throw errors, but we still need to be aware of those unexpected input.
|
test added |
meteorlxy
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.