Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] defineClientConfig is still broken under pnpm #1495

Closed
Mister-Hope opened this issue Feb 7, 2024 · 7 comments
Closed

[Bug report] defineClientConfig is still broken under pnpm #1495

Mister-Hope opened this issue Feb 7, 2024 · 7 comments
Labels
upstream bug Bug from upperchain or other tools, env, etc.

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 7, 2024

Description

See ecosystem, when removing the as ClientConfig and type import, type errors are still seen

image

Reproduction

https://github.com/vuepress/ecosystem

Used Package Manager

pnpm

System Info

.
@meteorlxy meteorlxy added the upstream bug Bug from upperchain or other tools, env, etc. label Feb 21, 2024
@github-actions github-actions bot added the stale label Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@Mister-Hope Mister-Hope added bug Something isn't working and removed stale labels Mar 24, 2024
@meteorlxy
Copy link
Member

Per microsoft/TypeScript#42873 (comment), it would be fixed in TS 5.5. Let's wait for the new release then.

@meteorlxy meteorlxy removed the bug Something isn't working label Apr 21, 2024
@github-actions github-actions bot added the stale label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@Mister-Hope Mister-Hope reopened this May 30, 2024
@Mister-Hope Mister-Hope removed the stale label May 30, 2024
Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@meteorlxy
Copy link
Member

Should have been solved since TS 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream bug Bug from upperchain or other tools, env, etc.
Projects
None yet
Development

No branches or pull requests

2 participants