Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Containers Don't Work #502

Open
1 task done
osarusan82 opened this issue Mar 2, 2024 · 1 comment
Open
1 task done

Nested Containers Don't Work #502

osarusan82 opened this issue Mar 2, 2024 · 1 comment
Assignees
Labels
design-needed Requires a designer's expertise enhancement New feature or request

Comments

@osarusan82
Copy link

What happened?

When a container is placed in another container, the nested container's contents do not display, and the weight of the nested container no longer calculates the weight of its contents.

What is the expected behaviour?

Expected behavior would be that a nested container would retain the weight of the container and also display the items inside it.

Relevant Errors and Warnings

No errors or warnings appear. Removing the nested container shows that the items are not lost; they reappear after removing the nested container. However they do seem to temporarily "disappear" from the game, as they become invisible and their weight stops being factored.

Additional Support Details

Foundry v. 11.315
OSE 1.10.1

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.10.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct
@osarusan82 osarusan82 added bug Something isn't working triage This bug still needs to be validated and weighted labels Mar 2, 2024
@anthonyronda anthonyronda added enhancement New feature or request and removed bug Something isn't working triage This bug still needs to be validated and weighted labels Apr 1, 2024
@anthonyronda
Copy link
Member

Changed to an enhancement request with design needed. Unfortunately, not showing the items inside is a design constraint.

the weight of the nested container no longer calculates the weight of its contents

This is a slightly poor design. Calculations are still going, but the column that is showing is actually the "quantity of items" column. Only Miscellaneous items have quantities.

If you or someone would like to help us design an elegant way to show what you want to see, we'd welcome giving your design a chance. I also welcome looking at #97 and seeing if you want to contribute your thoughts to that, because currently I don't think that does recursive items either

@anthonyronda anthonyronda added the design-needed Requires a designer's expertise label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-needed Requires a designer's expertise enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants