From a873ff0f69f3c5eb5e70ad374a6c4d25d0683b01 Mon Sep 17 00:00:00 2001 From: Vincenzo Sicurella Date: Thu, 18 Jul 2024 16:37:00 -0400 Subject: [PATCH 1/2] Return true on successful file read --- Source/lumatone_editor_library/data/lumatone_layout.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/lumatone_editor_library/data/lumatone_layout.cpp b/Source/lumatone_editor_library/data/lumatone_layout.cpp index 1d89731..d92fd0a 100644 --- a/Source/lumatone_editor_library/data/lumatone_layout.cpp +++ b/Source/lumatone_editor_library/data/lumatone_layout.cpp @@ -683,6 +683,8 @@ bool LumatoneLayout::fromStringArray(const juce::StringArray& stringArray) // boards[boardIndex].theKeys[55] = TerpstraKey(); // } //} + + return true; } juce::StringArray LumatoneLayout::toStringArray() const From eff870f8549b5697206079e444f2bed6025d042d Mon Sep 17 00:00:00 2001 From: Vincenzo Sicurella Date: Thu, 18 Jul 2024 16:37:25 -0400 Subject: [PATCH 2/2] Remove deprecated overriden method --- Source/MainWindow.cpp | 8 ++++---- Source/MainWindow.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Source/MainWindow.cpp b/Source/MainWindow.cpp index 0aa22f9..c24c9a8 100644 --- a/Source/MainWindow.cpp +++ b/Source/MainWindow.cpp @@ -81,10 +81,10 @@ void MainWindow::closeButtonPressed() JUCEApplication::getInstance()->systemRequestedQuit(); } -BorderSize MainWindow::getBorderThickness() const -{ - return BorderSize (1); -} +//BorderSize MainWindow::getBorderThickness() const +//{ +// return BorderSize (1); +//} bool MainWindow::isLargerThanCurrentScreen() const { diff --git a/Source/MainWindow.h b/Source/MainWindow.h index e924446..d8567cb 100644 --- a/Source/MainWindow.h +++ b/Source/MainWindow.h @@ -35,11 +35,11 @@ class MainWindow : public juce::DocumentWindow public: MainWindow(const LumatoneEditorState& stateIn, juce::ApplicationCommandManager* commandManager); - virtual ~MainWindow() override; + ~MainWindow() override; void closeButtonPressed() override; - juce::BorderSize getBorderThickness() const override; +// juce::BorderSize getBorderThickness() const override; /* Note: Be careful if you override any DocumentWindow methods - the base class uses a lot of them, so by overriding you might break its functionality.