Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random object being added to playmode #105

Closed
wants to merge 2 commits into from

Conversation

Happyrobot33
Copy link

Closes #96

Pretty simple fix, Assign the dummy gameobject created to a variable so we can destroy it once we are done with it

Copy link

@FairplexVR FairplexVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to instantiate a dummy object and destroy it later. We can just make a local variable and directly set its parent to the _mainSceneCamera

@Happyrobot33
Copy link
Author

Fair enough, didn't want to be responsible for breaking anything in case the object being in scene mattered :)

Copy link

@FairplexVR FairplexVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@momo-the-monster
Copy link
Collaborator

It looks like this was fixed in SDK 3.5.1, though the release notes did not mention it. Thanks for your contribution! That's why there's a conflict in the ClientSimStackedVRCameraSystem.cs file above.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted "New Game Object" in hierarchy
3 participants