Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allow_unverified_ssl option #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Jan 8, 2025

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Adds allow_unverified_ssl option to the provider to allow SSL connections with unverifiable certificates. Defaults to false.
  • Adds and/or updates the provider argument reference descriptions.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #44

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Updates release workflow.

Signed-off-by: Ryan Johnson <[email protected]>
Refactors `Makefile`.

Signed-off-by: Ryan Johnson <[email protected]>
- Adds `allow_unverified_ssl` option to the provider to allow SSL connections with unverifiable certificates. Defaults to `false`.
- Adds and/or updates the provider argument reference descriptions.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the enhancement Enhancement label Jan 8, 2025
@tenthirtyam tenthirtyam added this to the .next milestone Jan 8, 2025
@tenthirtyam tenthirtyam self-assigned this Jan 8, 2025
@github-actions github-actions bot added needs-review Needs Review documentation Documentation labels Jan 8, 2025
@tenthirtyam tenthirtyam added provider Provider and removed documentation Documentation labels Jan 8, 2025
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam modified the milestones: v0.4.4, Backlog, .next Jan 9, 2025
@tenthirtyam tenthirtyam force-pushed the main branch 13 times, most recently from e8b93d7 to 5bdacd5 Compare January 15, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement needs-review Needs Review provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for allow_unverified_ssl and remove disabled TLS certificate check.
2 participants