Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

(impact:high) [WidgetObject] internalFactory can be confusing #370

Open
2 tasks done
juanmendes opened this issue May 28, 2021 · 0 comments
Open
2 tasks done

(impact:high) [WidgetObject] internalFactory can be confusing #370

juanmendes opened this issue May 28, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@juanmendes
Copy link
Contributor

Prerequisites

[Check these off before submitting an issue].

  • Are you running the latest version?
  • Did you perform a basic issue search?

For more information, see the CONTRIBUTING guide.

Description

WidgetObject#internalFactory has caused confusion for developers. This causes a different way to interact with components depending on whether you're inside a WidgetObject or you're with a test (stepdef or unit test). To avoid this confusion, we should always expose WidgetObjectElements and callers can call unwrap() on their own if they want to use the T functionality that is specific to the testing framework being used.

This also avoids having a private and a public version of a method where the only difference is that the public one calls unwrap().

Impact

This is a breaking change, but we're the only users of this feature and I will update our internal vcd_ui app when this is finished.

@juanmendes juanmendes added the enhancement New feature or request label May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant