Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

(impact:high) Example of creating custom renderers #301

Open
2 tasks done
juanmendes opened this issue Jan 22, 2021 · 0 comments
Open
2 tasks done

(impact:high) Example of creating custom renderers #301

juanmendes opened this issue Jan 22, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@juanmendes
Copy link
Contributor

Prerequisites

  • Are you running the latest version? OR Are you submitting a bug for a prior version?
  • Did you perform a basic issue search?

Description

There is no example of how to create a custom column renderer on https://vmware.github.io/vmware-cloud-director-ui-components/datagrid/example/datagrid-three-renderers

The page does show a custom renderer being used:

        {
            displayName: 'Component Renderer',
            renderer: BoldTextRenderer((rec) => rec.name),
        },

But it does not show the implementation of BoldTextRenderer. It's currently being exported but it shouldn't. It should just be defined in the example itself

Impact

  • Some people gave up using the grid because they couldn't figure out how to get HTML in the grid cells.
  • Other people were able to use it, but they had to dig into the source code to figure out how to use it.

Steps to Reproduce

  1. Go to https://vmware.github.io/vmware-cloud-director-ui-components/datagrid/example/datagrid-three-renderers
  2. Click the <> icon to see the source
  3. Notice that we import { BoldTextRenderer... } from '@vcd/ui-components';

Expected behavior: [What you expected to happen]
The implementation of BoldTextRenderer should be inline and visible from the examples website
Actual behavior: [What actually happened]
The implementation is hidden in the gtihub's source code

Versions

Not version specific, present in latest

@juanmendes juanmendes added the bug Something isn't working label Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant