Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsl.plot: Convert .sh files to .vsh #115

Closed
ulises-jeremias opened this issue Oct 16, 2022 · 4 comments · Fixed by #173
Closed

vsl.plot: Convert .sh files to .vsh #115

ulises-jeremias opened this issue Oct 16, 2022 · 4 comments · Fixed by #173
Labels
good first issue Good for newcomers Hacktoberfest This label is assigned to any issue that is good to go for any Hacktoberfest participant

Comments

@ulises-jeremias
Copy link
Member

ulises-jeremias commented Oct 16, 2022

Seems that is it working on windows for users that have bash installed. So we need to figure out a way to know if bash is installed. Otherwise we need to provide another way of running the scripts that it provides

One way is to migrate all the .sh files in the plot/ dir to .vsh instead. That way VSL plot will be using V for mostly everything and just using python to run the plot server, which is a better way of doing it

Originally posted by @ulises-jeremias in #78 (comment)

@ulises-jeremias ulises-jeremias added the Hacktoberfest This label is assigned to any issue that is good to go for any Hacktoberfest participant label Oct 16, 2022
@AmitPress
Copy link
Contributor

I think, for this case, we must use platform independent APIs to translate the .sh files. I am actually trying to figure out how to translate the whole thing in such a way that it does not break in some particular operating systems. Hopefully, soon I will be on the task.

@AmitPress
Copy link
Contributor

Me myself had to actually struggled with windows. Then, I moved on wsl.

@JalonSolov
Copy link
Contributor

The beauty of .vsh files it that they are V script files, so they will do everything V will do in the same cross-platform manner as regular V programs.

@ulises-jeremias ulises-jeremias added the good first issue Good for newcomers label Oct 23, 2022
@ulises-jeremias
Copy link
Member Author

@AmitPress do you want me to assign this issue to you? we can also split it into different smaller tasks so we can migrate the scripts one by one 👌🏻

@ulises-jeremias ulises-jeremias removed the Hacktoberfest This label is assigned to any issue that is good to go for any Hacktoberfest participant label Apr 22, 2023
@ulises-jeremias ulises-jeremias added the Hacktoberfest This label is assigned to any issue that is good to go for any Hacktoberfest participant label Sep 19, 2023
@ulises-jeremias ulises-jeremias linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest This label is assigned to any issue that is good to go for any Hacktoberfest participant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants