add icon to gg.Config to be used with gg.new_context()

[YukiiVR]

Describe the feature

by adding a window icon to gg.Config, it allows for developers to add an optional icon while creating there window with gg.new_context(). this is still possible by manually creating the window with sokol (as seen on examples\sokol\08_sdf.v) but this would only make it slightly easier.

Use Case

this is still possible by manually creating the window with sokol (as seen on examples\sokol\08_sdf.v) but this would only make it slightly easier. in the case of someones project not having an icon and later adding one, they would not need to replace code to generate a window that allows an icon to be passed through, instead, we can just use gg.new_context(window_icon: sapp.IconDesk{...})

Proposed Solution

in the gg.Config struct, we can add window_icon which will be a sapp.IconDesc. then inside of the new_context method, we can add icon: cfg.window_icon

Other Information

I currently have a fork and branch that implements this at bd98905

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

Version used

V 0.4.8 77e4594

Environment details (OS name and version, etc.)

OS: windows, Microsoft Windows 10 Enterprise v19045 64-bit
Processor: 8 cpus, 64bit, little endian,

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

[spytheman]

imho just make a PR, since you already have it implemented

[YukiiVR]

I went ahead and did the PR (#23138), I'll go ahead and close this issue as well.

[JalonSolov]

If you add #<issue number> to the comment on a PR, the issue will be automatically closed when the PR is merged.

[YukiiVR]

If you add #<issue number> to the comment on a PR, the issue will be automatically closed when the PR is merged.

Did not know this, thanks for the tip!