Recommend removing numCells and friends from avtMeshMetaData

[markcmiller86]

Describe the bug

Another developer an into a field in avtMeshMetaData that is a bit odd and commented about it.

It is beign set in only four databases...

./databases/Vs/avtVsFileFormat.C
./databases/Geqdsk/avtGeqdskFileFormat.C
./databases/Nektar++/avtNektarPPFileFormat.C
./databases/M3DC1/avtM3DC1FileFormat.C

I went looking for whether hasNumberOfCells and numberCells are used or whether their respective setter/getters were used anywhere in VisIt. The only instance I found was...

visit/src/operators/IndexSelect/IndexSelectViewerEnginePluginInfo.C

Lines 270 to 277 in 9b3fbd1

	if( mmd->meshType == AVT_POINT_MESH ||
	mmd->meshType == AVT_UNSTRUCTURED_MESH)
	{
	isAtts->SetMaxDim(IndexSelectAttributes::OneD);
	isAtts->SetDim(IndexSelectAttributes::OneD);
	isAtts->SetXAbsMax(mmd->numberCells-1);
	if( isAtts->GetXMax() == -1 )
	isAtts->SetXMax(mmd->numberCells-1);

These fields appear to have been introduced by @ARSanderson back in 2011 and my guess is they were introduced to provide additional info in debug logging and then somehow got used in setting default maximum index for 1D index select operations. But, that will work only for the handful of database plugins that use it.

Helpful additional information

• Did VisIt crash:
• Did you get wrong results:

To Reproduce

Steps to reproduce the behavior. For example:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Additionally, please attach a (zipped) sessionfile to this ticket to easily reproduce (In the viewer, use File->Save Session).

Expected behavior

A clear and concise description of what you expected to happen.

Attachments

• Can you reproduce the bug on our test data?
  • If so, which file?
  • If not, access to your data would be very helpful. If the data set is small, please zip and upload it as an attachment. If it is large, please provide instructions for how we can contact you to obtain this data.
• Please attach a (zipped) sessionfile to easily reproduce (In the viewer, use File->Save Session).
• Please attach any screenshots relevant to understanding the issue.

Desktop

• OS and version: [e.g. Ubuntu 14.04]
• VisIt Version: [e.g. 2.13.3]
• Server info (if applicable):

Additional context

Add any other context about the problem here. Attach any (zipped) relevant files, such as data, configurations, sessionfiles, etc.