Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 1 in examples/docs.html is not working #72

Open
axelpale opened this issue May 9, 2015 · 2 comments
Open

Example 1 in examples/docs.html is not working #72

axelpale opened this issue May 9, 2015 · 2 comments

Comments

@axelpale
Copy link
Collaborator

axelpale commented May 9, 2015

The public documentation at visionmedia.github.io/move.js/ uses version 0.3.2 (open console & type move.version) and there Example 1 works as expected. However if you clone 0.4.0 and open examples/docs.html all the other examples work as expected but Example 1 does not do anything.

I did not yet found any reason why this happens. Others experiencing the same issue?

@yinjun1991
Copy link

I think the code of example-1 has some problems. It should be like this:
move('#example-1 .box').set('margin-left', "200px").end();
don`t forget the 'px';

@JimYan
Copy link

JimYan commented Jul 21, 2016

The master applyProperties Code is:
Move.prototype.applyProperties = function(){
for (var prop in this._props) {
this.el.style.setProperty(prop, this._props[prop], '');
}
return this;
};

But the page http://visionmedia.github.io/move.js/ is:
Move.prototype.applyProperties = function(){
css(this.el, this._props);
return this;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants