Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect information about quotes in URLs in FST files #182

Open
ksuprynowicz opened this issue Sep 30, 2021 · 3 comments
Open

Incorrect information about quotes in URLs in FST files #182

ksuprynowicz opened this issue Sep 30, 2021 · 3 comments

Comments

@ksuprynowicz
Copy link

I encoutered this problem trying to use custom animation graph for an avatar. When link was in quotes, it would silently load default animation graph instead, whitout any message in the logs. So for example:
animGraphUrl = "http://oaktown.pl/test/avatar-animation.json"
wouldn't work, and:
animGraphUrl = http://oaktown.pl/test/avatar-animation.json
would work correctly.
Documentation suggests using quotes around URL, which is misleading, and shouild be updated:
animGraphUrl = "URL"
Should be:
animGraphUrl = URL
With a note saying that it won't work with quotes.

@0Bondrewd
Copy link
Contributor

Which documentation suggests surrounding quotes with URL's?

@JulianGro
Copy link
Contributor

JulianGro commented Sep 30, 2021

$ grep -r "animGraphUrl" *
create/avatars/custom-animations.rst:    animGraphUrl = "URL"
$ 

@ksuprynowicz
Copy link
Author

ksuprynowicz commented Sep 30, 2021

Which documentation suggests surrounding quotes with URL's?

I found one here, but there may be more. It would be best to search for FST in documentation
https://docs.vircadia.com/create/avatars/custom-animations.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants