Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagging reviews, moving unreviewed code to production, branching issues #73

Open
inetaa opened this issue Sep 8, 2016 · 2 comments
Open

Comments

@inetaa
Copy link
Collaborator

inetaa commented Sep 8, 2016

Hi,

Slow code reviewing leads to some project management issues. Firstly, as we already launched the app to production, we need to move features and especially bug fixes to production more quickly and therefore unreviewed code goes to production. The second issue is making separate branches for different issues but as reviews are lagging, it is not possible to merge them and release them. And these limitations led to one huge PR which haven't been reviewed for 16 days now and it's growing due to uncertainty when it's going to be reviewed.

How could we make this reviewing process more efficient? Any other ideas how to improve overall development process?

@tadaskay
Copy link
Member

May I suggest making PRs smaller and more focused so they are easier to comprehend and review? I don't know the exact reasons it's not moving, but in general +1,126 −815 is quite huge. Personally I would even go as far as denying it and requesting to split into more specific PRs.

@ViliusKraujutis
Copy link
Member

I suggest moving on with a policy requiring just for a single 👍 for a PR to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants