Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add svg support #2

Open
vidhanio opened this issue Jan 13, 2024 · 2 comments · May be fixed by #1
Open

add svg support #2

vidhanio opened this issue Jan 13, 2024 · 2 comments · May be fixed by #1
Labels
enhancement New feature or request

Comments

@vidhanio
Copy link
Owner

vidhanio commented Jan 13, 2024

No description provided.

@vidhanio vidhanio linked a pull request Jan 13, 2024 that will close this issue
@vidhanio vidhanio assigned vidhanio and unassigned vidhanio Jan 18, 2024
@vidhanio vidhanio added the enhancement New feature or request label Jan 18, 2024
@Brocktho
Copy link

Brocktho commented Jan 4, 2025

Would love to add interest to SVG support, looked at that PR mentioned and it does work out of the box no real issues. I saw you didn't like the feature flag and maybe wanted some more documentation surrounding those elements. I started going through and trying to make those fixes but while doing so I had a couple questions for your preference on it

@Brocktho
Copy link

Brocktho commented Jan 5, 2025

Would you prefer that all SVG elements are added inside the elements! macro? or rather have them sidecar (in their own svg_elements!) like that pull request draft has? If putting them all into the elements! macro the svg global props are much more limited than most elements and would either want a refactor of many existing elements or to accept that about 20 attributes are "acceptable" for svg elements to have on them but not technically valid by spec.

While I was digging into this I also found a number of "GlobalAttributes" that aren't technically global based on the spec here: MDN Dev Docs. Would you like those to be refactored? Or I'm assuming some of these are custom element attributes for web components that I might not know of? (some examples: autofocus, enterkeyhint, is, itemid, etc.)

Curious what you'd prefer, I'd be fine to do any of the options (sidecar, add them to main elements without refactor, add them to main elements with larger refactor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants