Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting and loading spinner is not triggered on fast quality change #1557

Open
pclarke-coursera opened this issue Dec 9, 2024 · 1 comment

Comments

@pclarke-coursera
Copy link

Whenever the video quality changes for HLS (either manually or via auto resolution switching), there is no loading spinner shown even though the waiting event is triggered. In video.js's source code, we can see that the vjs-waiting class is added which will trigger the loading spinner. However, even though the video player is in a waiting state when you try to switch resolutions quickly, there is no automatic loading spinner.

Expected result:
When a video quality change occurs and the video is buffering, show the loading spinner to appropriately respond to the waiting event.

Reproduction steps:
Visit https://videojs-http-streaming.netlify.app/?debug=false&autoplay=false&muted=false&fluid=false&minified=false&sync-workers=false&liveui=true&llhls=true&url=https%3A%2F%2Fbitdash-a.akamaihd.net%2Fcontent%2FMI201109210084_1%2Fm3u8s-fmp4%2Ff08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8&type=application%2Fx-mpegurl&keysystems=&buffer-water=false&exact-manifest-timings=false&pixel-diff-selector=false&network-info=false&dts-offset=false&override-native=true&use-mms=true&preload=auto&mirror-source=true&forced-subtitles=false and try to quickly change the resolutions. Sometimes you will see the video content freeze without any loading spinner to indicate something is happening.

Copy link

welcome bot commented Dec 9, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant