Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping jQuery #792

Open
perdedora opened this issue Aug 14, 2024 · 4 comments
Open

Dropping jQuery #792

perdedora opened this issue Aug 14, 2024 · 4 comments

Comments

@perdedora
Copy link
Member

I think we began using because was easier and cross compatibility between browsers. But this was ~10 years ago, now vanilla javascript can achieve everything we do and remove the sluggish of jQuery.

Plus most of the scripts are almost illegible hacking away trying to make it work and this are going to give us a opportunity to make it easier to debug.

@crazy4cars69
Copy link

If it ain't broke, don't fix it. But i don't think old jquery is eating RAM that much.

@andrewwhiteingale
Copy link

that will require removing a lot of written javascript by czaks. quite many of them use jquery in practically everywhere.

@perdedora
Copy link
Member Author

I've rewritten a lot of the scripts we use already. There's only a few left (customized post-hover, quick-reply, post menu, post filter, fix report... and file selector)

I can see some improvements by using async/await/promise functions.
The page loads improved (although this may be because of preload), and improved readability a lot.

@ghost
Copy link

ghost commented Sep 6, 2024

@perdedora Your idea has obvious merit, as vanilla js has came a long way. Vanilla js would make the js functions more reliable and modernized and modular. With that being said, i give you full authority to go ahead and make the changes. Also, go ahead and update everything to php 8.4, i grant you full authority to do that, too. If anyone asks, just say i gave the green light. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants