Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add veterans.gc.ca menu to header #1958

Open
smcmurtry opened this issue Mar 6, 2019 · 3 comments
Open

Add veterans.gc.ca menu to header #1958

smcmurtry opened this issue Mar 6, 2019 · 3 comments

Comments

@smcmurtry
Copy link
Collaborator

Just the menu button, not the search box: https://app.zeplin.io/project/5acbd659dc553ec84805afd4/screen/5b758b92156c13b1cbd5a0a0

For this we can use the same approach as #1950, although we will also need to include some javascript from the VAC site to make the menu work.

screen shot 2019-03-06 at 4 37 08 pm

@smcmurtry smcmurtry self-assigned this Mar 6, 2019
@smcmurtry
Copy link
Collaborator Author

1 similar comment
@smcmurtry
Copy link
Collaborator Author

@smcmurtry
Copy link
Collaborator Author

Here's where I got to with this:

  • I used the approach described in VAC footer #1950 to create a component for the menu bar, removing the elements for the search box since this is not in the designs
  • The menu button needs javascript to function, so as an initial attempt to get it working I copied all the imported js files from the html source for veterans.gc.ca into pages/_document.js
  • The menu button then worked but the expansion was hidden behind other page content. I added a higher z-index value to the styling for the menu bar but this didn't fix the issue (although it's possible I didn't modify the index on the correct component).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant