Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on deploy if set_language isn't at the top of a schema. #33053

Open
kdutia opened this issue Dec 19, 2024 · 0 comments
Open

Warn on deploy if set_language isn't at the top of a schema. #33053

kdutia opened this issue Dec 19, 2024 · 0 comments

Comments

@kdutia
Copy link

kdutia commented Dec 19, 2024

Is your feature request related to a problem? Please describe.
I've implemented set_language to set the two documents in my schema to English. A PR review picked up the note in your docs that the field should be the first field in the document. I've changed this, however am worried that future developers on our schema might not know this and might put a field above it which is then unaffected by this language setting.

Describe the solution you'd like
I find warnings about schemas really useful when doing a local deploy, and thought this would be a useful extra warning to add.

Describe alternatives you've considered
Adding a comment to the schema for future developers instead, but I can't figure out whether it's possible to add comments to .sd files.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant