From 87b8befc37fbfb3115dc1248b8266438d82c5eeb Mon Sep 17 00:00:00 2001
From: Marlon Saglia <marlon@vespa.ai>
Date: Wed, 2 Oct 2024 10:18:30 +0200
Subject: [PATCH] chore: improve cleaner script output

---
 .github/scripts/delete-old-cloudsmith-artifacts.sh | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/scripts/delete-old-cloudsmith-artifacts.sh b/.github/scripts/delete-old-cloudsmith-artifacts.sh
index 98ff14ec638e..fc62ceb2f176 100755
--- a/.github/scripts/delete-old-cloudsmith-artifacts.sh
+++ b/.github/scripts/delete-old-cloudsmith-artifacts.sh
@@ -9,7 +9,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-dnf install -y 'dnf-command(config-manager)' jq
+dnf install -yq 'dnf-command(config-manager)' jq
 
 MAX_NUMBER_OF_RELEASES=32
 LAST_VESPA_7_RELEASE="7.594.36"
@@ -44,10 +44,10 @@ for VERSION in $VERSIONS_TO_DELETE; do
     "https://api.cloudsmith.io/v1/packages/vespa/open-source-rpms/?query=version:${VERSION}" | jq -re '.[] | .slug' >> $RPMS_TO_DELETE
 done
 
-echo "Deleting the following RPMs:"
-cat $RPMS_TO_DELETE
-
 if [[ "$GITHUB_EVENT_NAME" == "schedule" || "$GITHUB_EVENT_NAME" == "workflow_dispatch" ]]; then
+    echo "Deleting the following RPMs:"
+    cat $RPMS_TO_DELETE
+
     for RPMID in $(cat $RPMS_TO_DELETE); do
       curl --silent --show-error --location --fail \
         --request DELETE \
@@ -55,4 +55,7 @@ if [[ "$GITHUB_EVENT_NAME" == "schedule" || "$GITHUB_EVENT_NAME" == "workflow_di
         --header 'accept: application/json' \
         "https://api.cloudsmith.io/v1/packages/vespa/open-source-rpms/$RPMID/"
     done
+else
+    echo "Dry-run: Would have deleted the following RPMs:"
+    cat $RPMS_TO_DELETE
 fi