diff --git a/searchlib/src/vespa/searchlib/docstore/randreaders.cpp b/searchlib/src/vespa/searchlib/docstore/randreaders.cpp index 5d1581106452..c26ad1aff8cb 100644 --- a/searchlib/src/vespa/searchlib/docstore/randreaders.cpp +++ b/searchlib/src/vespa/searchlib/docstore/randreaders.cpp @@ -27,6 +27,8 @@ DirectIORandRead::DirectIORandRead(const std::string & fileName) } } +DirectIORandRead::~DirectIORandRead() = default; + FileRandRead::FSP DirectIORandRead::read(size_t offset, vespalib::DataBuffer & buffer, size_t sz) { @@ -64,6 +66,7 @@ MMapRandRead::MMapRandRead(const std::string & fileName, int mmapFlags, int fadv } } +MMapRandRead::~MMapRandRead() = default; NormalRandRead::NormalRandRead(const std::string & fileName) : _file(std::make_unique(fileName.c_str())) @@ -73,6 +76,8 @@ NormalRandRead::NormalRandRead(const std::string & fileName) } } +NormalRandRead::~NormalRandRead() = default; + FileRandRead::FSP MMapRandRead::read(size_t offset, vespalib::DataBuffer & buffer, size_t sz) { @@ -103,6 +108,8 @@ MMapRandReadDynamic::MMapRandReadDynamic(const std::string &fileName, int mmapFl remap(0); } +MMapRandReadDynamic::~MMapRandReadDynamic() = default; + void MMapRandReadDynamic::remap(size_t sz) { diff --git a/searchlib/src/vespa/searchlib/docstore/randreaders.h b/searchlib/src/vespa/searchlib/docstore/randreaders.h index 97e40a6f1f7b..0bbae451d162 100644 --- a/searchlib/src/vespa/searchlib/docstore/randreaders.h +++ b/searchlib/src/vespa/searchlib/docstore/randreaders.h @@ -14,6 +14,7 @@ class DirectIORandRead : public FileRandRead { public: DirectIORandRead(const std::string & fileName); + ~DirectIORandRead() override; FSP read(size_t offset, vespalib::DataBuffer & buffer, size_t sz) override; int64_t getSize() const override; private: @@ -27,6 +28,7 @@ class MMapRandRead : public FileRandRead { public: MMapRandRead(const std::string & fileName, int mmapFlags, int fadviseOptions); + ~MMapRandRead() override; FSP read(size_t offset, vespalib::DataBuffer & buffer, size_t sz) override; int64_t getSize() const override; const void * getMapping(); @@ -38,6 +40,7 @@ class MMapRandReadDynamic : public FileRandRead { public: MMapRandReadDynamic(const std::string & fileName, int mmapFlags, int fadviseOptions); + ~MMapRandReadDynamic() override; FSP read(size_t offset, vespalib::DataBuffer & buffer, size_t sz) override; int64_t getSize() const override; private: @@ -54,6 +57,7 @@ class NormalRandRead : public FileRandRead { public: NormalRandRead(const std::string & fileName); + ~NormalRandRead() override; FSP read(size_t offset, vespalib::DataBuffer & buffer, size_t sz) override; int64_t getSize() const override; private: