From d58e5d8d5b7ad05a0cbc82765d685211c2d0e0c9 Mon Sep 17 00:00:00 2001
From: Laura Perry <10005215+lperry25@users.noreply.github.com>
Date: Fri, 20 Dec 2024 11:10:54 +0100
Subject: [PATCH] fix bug when mode is null

---
 _includes/navbar.html | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/_includes/navbar.html b/_includes/navbar.html
index 250cf3c6f8..dcc3f18749 100644
--- a/_includes/navbar.html
+++ b/_includes/navbar.html
@@ -1,7 +1,7 @@
 <!-- Copyright Vespa.ai. All rights reserved.. -->
 <script>
 
-	function setmodeParam(mode) {
+	function setModeParam(mode) {
 		const currentUrl = new URL(window.location.href);  // Get the current URL
 		const urlParams = new URLSearchParams(currentUrl.search);
 		urlParams.set('mode', mode);  // Set or update the query parameter
@@ -23,7 +23,7 @@
 		}
 	}
 	
-	function handleCurrentmode(currentmode){
+	function handleCurrentMode(currentmode){
         localStorage.setItem('mode', currentmode);
 		if (currentmode === 'cloud'){
 			hideElements('selfhosted');
@@ -33,9 +33,9 @@
 			showElements('selfhosted')
 		}
 	}
-	function selectmode(mode) {
-		setmodeParam(mode);
-		handleCurrentmode(mode);
+	function selectMode(mode) {
+		setModeParam(mode);
+		handleCurrentMode(mode);
 	}
 
 	document.addEventListener('DOMContentLoaded', function() {
@@ -44,10 +44,11 @@
 		let currentmode = urlParams.get('mode');
         if (!currentmode) {
             currentmode = localStorage.getItem('mode');
-            setmodeParam(currentmode);
+            if (currentmode) {
+                setModeParam(currentmode);
+            } else if (!currentmode) {
             // This is temporairly added so that we can test the new mode selector
             // The selector will only appear if there is ?mode= in the url or if it is stored in local storage
-            if (!currentmode) {
                 document.getElementById('docs-mode').classList.add('hide');
                 document.getElementById('sidebar').classList.remove('p-t-35');
                 showElements('cloud');
@@ -55,14 +56,14 @@
             }
         }
 		
-		if(currentmode){
+		if(currentmode !== null){
 			document.getElementById('docs-mode').value = currentmode;
-			handleCurrentmode(currentmode);
+			handleCurrentMode(currentmode);
 		}
 
 		document.getElementById('docs-mode').addEventListener('change', function() {
 			const selectedValue = this.value;
-			selectmode(selectedValue);
+			selectMode(selectedValue);
 		});
 	});