Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract logic in Batcher::add_transaction_to_account() #222

Open
andrewvious opened this issue Jun 18, 2024 · 0 comments · May be fixed by #226
Open

Abstract logic in Batcher::add_transaction_to_account() #222

andrewvious opened this issue Jun 18, 2024 · 0 comments · May be fixed by #226
Assignees
@andrewvious
Labels
code quality Improves either readability of code, or organizational structure

Comments

@andrewvious
Copy link
Contributor

andrewvious commented Jun 18, 2024 •
edited
Loading

The function is currently very robust, repetitive and difficult to read. Abstracting the logic into separate functions will help with readability, and adding additional documentation would be beneficial as well.
@andrewvious andrewvious added the code quality Improves either readability of code, or organizational structure label Jun 18, 2024
@andrewvious andrewvious self-assigned this Jun 18, 2024
@andrewvious andrewvious linked a pull request Jun 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvious andrewvious

Labels
code quality Improves either readability of code, or organizational structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abstract & Update logic in Batcher::add_transaction_to_account() versatus/lasr
1 participant
@andrewvious