Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails under path with whitespaces #753

Closed
nazar-pc opened this issue Jan 11, 2022 · 12 comments · Fixed by #1239
Closed

Installation fails under path with whitespaces #753

nazar-pc opened this issue Jan 11, 2022 · 12 comments · Fixed by #1239
Assignees
Labels

Comments

@nazar-pc
Copy link
Collaborator

Bug Report

Your environment

  • mediasoup version: 3.9.4

Issue description

When installed under directory whose path has whitespaces, installation fails, see https://mediasoup.discourse.group/t/mediasoup-installation-issue-ubuntu-20-04-node-16-13-1-pip-21-3-1-python-3-8-10/3804, we need to fix that.

@nazar-pc nazar-pc added the bug label Jan 11, 2022
@nazar-pc nazar-pc self-assigned this Jan 11, 2022
@ibc
Copy link
Member

ibc commented Jan 11, 2022

Is this a bug in our code or in some underlying lib or build system?

@nazar-pc
Copy link
Collaborator Author

I believe some paths need to be taken into quotes in the Makefile, didn't dig into details yet, so it is all on our side.

@techhjork
Copy link

techhjork commented Jan 12, 2022

Creating Mediasoup Files in using other other local disk space in Dual Boot

Basically i am on Dual boot and using other local disk space 'Volume/Backend/mediasoup/mediasoup-3'
so maybe thats why i was facing that issue that time

But as @nazar-pc said for changing directory
i clone that repo. in Desktop and same process and issue resolved but getting some warning

Link of warning of C in Mediasoup Discourse
image

hope Mediasoup Team will fix these also

And Thanks for this helping Community

i will ask more Questions in future

@CosmosisT
Copy link

The whitespace is a feature I thought?

@ibc
Copy link
Member

ibc commented Dec 10, 2022

When installed under directory whose path has whitespaces, installation fails, see https://mediasoup.discourse.group/t/mediasoup-installation-issue-ubuntu-20-04-node-16-13-1-pip-21-3-1-python-3-8-10/3804

@nazar-pc the linked post doesn't seem related to having white spaces in the installation path, do I miss something?

@nazar-pc
Copy link
Collaborator Author

nazar-pc commented Dec 10, 2022

It does, see, target is /media/tech/New Volume/Backend/mediasoup/mediasoup-3/worker/out/pip, then you see "invalid requirement", which is suspiciously the part of the path after whitespace:

ERROR: Invalid requirement: 'Volume/Backend/mediasoup/mediasoup-3/worker/out/pip'

@ibc ibc changed the title Fix installation under path with whitespaces Installation fails under path with whitespaces Dec 10, 2022
ibc added a commit to versatica/mediasoup-website that referenced this issue Dec 10, 2022
@ibc
Copy link
Member

ibc commented Dec 10, 2022

I've tried everything and this is hell. Not even sure there is a fix, and impossible to fix it in all OS.

So I've fixed this issue another way:

CleanShot-2022-12-10-at-13 21 51@2x

@ibc ibc closed this as completed Dec 10, 2022
@nazar-pc
Copy link
Collaborator Author

I'm sure there is a fix, but not sure we want it in the codebase. Not supporting whitespaces is certainly one way to "fix" it 😂

@ibc
Copy link
Member

ibc commented Dec 10, 2022

Searching for "Makefile whitespaces" is just maddening. I just gave up. Add I love the fix 😅

@RamanSB
Copy link

RamanSB commented Nov 10, 2023

I would not say this issue has been resolved. I had a whitespace in my Filepath and it didn't work, when the whitespace was removed - it worked.

@ibc
Copy link
Member

ibc commented Nov 10, 2023

Yes. As explained in comments above we gave up. And we documented that the installation path cannot have white spaces. PRs are welcome, we don't know how to fix that.

@ibc
Copy link
Member

ibc commented Nov 26, 2023

This is probably fixed in PR #1239 in commit c7720f2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

5 participants