Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing iceServers / iceTransportPolicy parameters when creating transport #165

Open
fedulvtubudul opened this issue Aug 1, 2023 · 2 comments

Comments

@fedulvtubudul
Copy link
Contributor

TypeScript version of mediasoup client has iceServers and iceTransportPolicy parameters when calling createSendTransport method on Device entity: method declaration. C++ implementation of the libmediasoupclient does not have these parameters: method declaration.

Previously I've used UpdateIceServers method of the Transport entity and added UpdateIceTransportType method in our fork to set these parameters. But I guess it will be nice to have more consistent APIs between TS and C++ implementations, so I suggest adding missing parameters to Transport constructor. I was also motivated to open this issue by another one in our Swift wrapper for libmediasoupclient that suggested same way to set iceServers in TS and Swift.

I'll try to implement it myself and make a PR, but please say if I'm moving the right direction.

@jmillan
Copy link
Member

jmillan commented Aug 1, 2023

libmediasoup and mediasop-client should be in sync, being mediasoup-client the original implementation, so yes. That's a right move.

But please, check the commit where it was implemented in TS and implement it accordingly in libmediasoupclient.

@fedulvtubudul
Copy link
Contributor Author

While there are no iceServers and iceTransportPolicy parameters declared explicitly in the C++ library (and thats what confused me in the first place). Still looks like their values can be passed via peerConnectionOptions.config. So maybe we just need to add some explanation to the corresponding documentation paragraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants