You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TypeScript version of mediasoup client has iceServers and iceTransportPolicy parameters when calling createSendTransport method on Device entity: method declaration. C++ implementation of the libmediasoupclient does not have these parameters: method declaration.
Previously I've used UpdateIceServers method of the Transport entity and added UpdateIceTransportType method in our fork to set these parameters. But I guess it will be nice to have more consistent APIs between TS and C++ implementations, so I suggest adding missing parameters to Transport constructor. I was also motivated to open this issue by another one in our Swift wrapper for libmediasoupclient that suggested same way to set iceServers in TS and Swift.
I'll try to implement it myself and make a PR, but please say if I'm moving the right direction.
The text was updated successfully, but these errors were encountered:
While there are no iceServers and iceTransportPolicy parameters declared explicitly in the C++ library (and thats what confused me in the first place). Still looks like their values can be passed via peerConnectionOptions.config. So maybe we just need to add some explanation to the corresponding documentation paragraph.
TypeScript version of mediasoup client has
iceServers
andiceTransportPolicy
parameters when callingcreateSendTransport
method onDevice
entity: method declaration. C++ implementation of the libmediasoupclient does not have these parameters: method declaration.Previously I've used
UpdateIceServers
method of theTransport
entity and addedUpdateIceTransportType
method in our fork to set these parameters. But I guess it will be nice to have more consistent APIs between TS and C++ implementations, so I suggest adding missing parameters to Transport constructor. I was also motivated to open this issue by another one in our Swift wrapper for libmediasoupclient that suggested same way to set iceServers in TS and Swift.I'll try to implement it myself and make a PR, but please say if I'm moving the right direction.
The text was updated successfully, but these errors were encountered: