Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must support a=rtcp-fb:* when checking RTP capabilities #153

Open
ibc opened this issue Jan 18, 2023 · 0 comments
Open

Must support a=rtcp-fb:* when checking RTP capabilities #153

ibc opened this issue Jan 18, 2023 · 0 comments

Comments

@ibc
Copy link
Member

ibc commented Jan 18, 2023

(Same as in mediasoup-client: versatica/mediasoup-client#239).

a=rtcp-fb:* means that all codecs in this m= section support the RTCP features exposed in this attribute line. Purpose of it is to save space in the SDP by reducing number of a=rtcp-fb lines per m= section. libwebrtc will support this soon so we must be ready in mediasoup-client and libmediasoupclient.

Example:
a=rtcp-fb:* transport-cc means that all codecs in this m= section support transport-cc.

NOTE: This is a SDP thing. We transmit ORTC parameters from client to mediasoup and vice-versa. AFAIU we don't need to support this neither in mediasoup side nor in the ORTC parameters, utils and definitions within mediasoup-client and libmediasoupclient.

So basically, when we parse a SDP and generate RtpParameters or RtpCapabilities must be ready to manage a=rtcp-fb:* lines and apply their supported RTCP features into all codecs within the generated RtpParameters or RtpCapabilities. This is just an estimation, things may need to be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant