Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename label from "temp hum" to "temp bms" #317

Closed
wants to merge 1 commit into from

Conversation

surfdado
Copy link
Contributor

this has been driving me nuts for a while - am I misunderstanding something or does my proposed change make sense?

@vedderb
Copy link
Owner

vedderb commented May 12, 2023

Temp hum is the temperature of the humidity sensor (on hardware that has one).

@surfdado
Copy link
Contributor Author

Temp hum is the temperature of the humidity sensor (on hardware that has one).

Yes, I figured this much - but do you agree with the proposed change? Kevin from Ennoid does

@surfdado
Copy link
Contributor Author

@vedderb ping

@Relys
Copy link
Contributor

Relys commented Nov 4, 2023

This always confused me. Glad I'm not the only one. XD

@surfdado
Copy link
Contributor Author

@vedderb ?

@vedderb
Copy link
Owner

vedderb commented Nov 26, 2023

I still don't agree on that naming. Why would temp bms be the temperature of the humidity sensor when there are so many other sensors that measure temperature too?

@surfdado
Copy link
Contributor Author

surfdado commented Jan 3, 2024

I still don't agree on that naming. Why would temp bms be the temperature of the humidity sensor when there are so many other sensors that measure temperature too?

I still think that for the average user "temp hum" is meaningless, took me weeks to figure out. Most wouldn't know that this refers to the temperature of their BMS. As far as I'm concerned "temp bms" is still the most appropriate label, as it is usually the one and only temperature telling you how hot your BMS is, it just happens to be part of the humidity sensor.

@vedderb
Copy link
Owner

vedderb commented Jan 3, 2024

The issue is that what I usually care about when it comes to the BMS temperature is how hot the balancing resistors are or the charge switch is (the critical temperature of the BMS itself). The 12s7p has a sensor near the balancing resistors and the 18s light bms has one near the charge switch. The humidity sensor is deliberately placed far away from things that get hot as higher temperature makes the relative humidity go down, so it will measure the least critical temperature.

@surfdado
Copy link
Contributor Author

surfdado commented Jan 4, 2024

Okay, I understand now, sounds like the user-defined temp sensors can also be used on the BMS. However, I still wish we had a way to make it more obvious to the user which temperature are related to the BMS temp versus the cell temps.

@surfdado surfdado closed this Jan 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants