Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmojiManager.getForTag - CaseInsensitive #167

Open
ccostin93 opened this issue Dec 1, 2020 · 0 comments
Open

EmojiManager.getForTag - CaseInsensitive #167

ccostin93 opened this issue Dec 1, 2020 · 0 comments

Comments

@ccostin93
Copy link

ccostin93 commented Dec 1, 2020

Currently, the method EmojiManager.getForTag(String) is case sensitive. I would say this is quite restrictive.

Sure, one can do a call for EmojiManager.getAllTags(), but then one would have to search though all the tags and find what he wants.

A simple improvement would be to make the Map storing the emojis by tag to be case insensitive. This can be achieved by changing the HashMap to a TreeMap(CASE_INSENSITIVE) - see https://www.baeldung.com/java-map-with-case-insensitive-keys

@vdurmont WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant