Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Save" saves to wrong file and you don't know #880

Open
HorstBaerbel opened this issue Jun 24, 2023 · 1 comment
Open

[Bug] "Save" saves to wrong file and you don't know #880

HorstBaerbel opened this issue Jun 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@HorstBaerbel
Copy link

HorstBaerbel commented Jun 24, 2023

Operating system and application version

  • OS: Fedora 38
  • Version 3.29.1

Describe the bug
The "Save" / "Save As" feature has a couple of small problems:

  • [Bug] When opening a different preset than the current one "Save" will still save to the PREVIOUS opened file. Related:
  • [Feature] You have no idea which file was loaded, so you also have no idea which file will be saved when pressing "Save". The file name in the application title bar would work wonders.
  • [Bug] The first "Open" remembers the last path (even after application shutdown), which is good, but after loading a file "Save" and "Save As" do not (neither path nor file name). Imo they should start where the last loaded file (if any) was.

To Reproduce
Steps to reproduce the behavior:

  1. Save two presets. Close application. Open Application.
  2. "Open" -> path remembered
  3. "Save" / "Save As" -> path not remembered
  4. "Save As" to file A
  5. "Open" file B
  6. "Save" -> still saves to file A

Expected behavior
Save to correct file and show file name or elided path in title bar

Additional context
Related #851

@2xAA
Copy link
Member

2xAA commented Jun 29, 2023

Ah damn, thanks for reporting!
Might be a few weeks until I can fix and test this properly, moving house.

@TimPietrusky - if you have time in the next week or so could you take a look?

If you want to draft a PR, the approach is pretty much:

Essentially, after this line
https://github.com/vcync/modV/blob/next/src/background/menu-bar.js#L101

copy and paste this line
https://github.com/vcync/modV/blob/next/src/background/menu-bar.js#L28

@2xAA 2xAA added the bug Something isn't working label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants